Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Side by Side Diff: lib/compiler/implementation/dart_backend/backend.dart

Issue 10826259: Collect referenced classes recursively. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | tests/language/language.status » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class DartBackend extends Backend { 5 class DartBackend extends Backend {
6 final List<CompilerTask> tasks; 6 final List<CompilerTask> tasks;
7 final UnparseValidator unparseValidator; 7 final UnparseValidator unparseValidator;
8 8
9 Map<Element, TreeElements> get resolvedElements() => 9 Map<Element, TreeElements> get resolvedElements() =>
10 compiler.enqueuer.resolution.resolvedElements; 10 compiler.enqueuer.resolution.resolvedElements;
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 final Element element; 134 final Element element;
135 final TreeElements treeElements; 135 final TreeElements treeElements;
136 final Set<TypedefElement> typedefs; 136 final Set<TypedefElement> typedefs;
137 final Set<ClassElement> classes; 137 final Set<ClassElement> classes;
138 138
139 ReferencedElementCollector( 139 ReferencedElementCollector(
140 this.compiler, 140 this.compiler,
141 this.element, this.treeElements, 141 this.element, this.treeElements,
142 this.typedefs, this.classes); 142 this.typedefs, this.classes);
143 143
144 void collectElement(Element element) {
Anton Muhin 2012/08/13 08:15:30 nit: please, do not shadow the field.
Roman 2012/08/13 08:23:08 Renamed field to rootElement.
145 new ReferencedElementCollector(
146 compiler, element, new TreeElementMapping(), typedefs, classes)
147 .collect();
148 }
149
144 visitNode(Node node) { node.visitChildren(this); } 150 visitNode(Node node) { node.visitChildren(this); }
145 151
146 visitTypeAnnotation(TypeAnnotation typeAnnotation) { 152 visitTypeAnnotation(TypeAnnotation typeAnnotation) {
147 final type = compiler.resolveTypeAnnotation(element, typeAnnotation); 153 final type = compiler.resolveTypeAnnotation(element, typeAnnotation);
148 Element typeElement = type.element; 154 Element typeElement = type.element;
149 if (typeElement.isTypedef() && !typedefs.contains(typeElement)) { 155 if (typeElement.isTypedef() && !typedefs.contains(typeElement)) {
150 typedefs.add(typeElement); 156 typedefs.add(typeElement);
151 new ReferencedElementCollector( 157 collectElement(typeElement);
152 compiler, typeElement, new TreeElementMapping(), typedefs, classes)
153 .collect();
154 } 158 }
155 if (typeElement.isClass()) classes.add(typeElement); 159 if (typeElement.isClass() && !classes.contains(typeElement)) {
160 classes.add(typeElement);
161 collectElement(typeElement);
162 }
156 typeAnnotation.visitChildren(this); 163 typeAnnotation.visitChildren(this);
157 } 164 }
158 165
159 void collect() { 166 void collect() {
160 compiler.withCurrentElement(element, () { 167 compiler.withCurrentElement(element, () {
161 element.parseNode(compiler).accept(this); 168 element.parseNode(compiler).accept(this);
162 }); 169 });
163 } 170 }
164 } 171 }
OLDNEW
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | tests/language/language.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698