Don't traverse through junctions when recursively deleting on Windows.

Don't traverse through junctions when recursively deleting on Windows.

Committed: https://code.google.com/p/dart/source/detail?r=11005

[Bob Nystrom, 2012-08-17 03:11:48]

Fixes:

http://code.google.com/p/dart/issues/detail?id=4560
http://code.google.com/p/dart/issues/detail?id=4406

[Søren Gjesse, 2012-08-17 07:07:37]

lgtm

https://chromiumcodereview.appspot.com/10825413/diff/1/runtime/bin/directory_...
File runtime/bin/directory_win.cc (right):

https://chromiumcodereview.appspot.com/10825413/diff/1/runtime/bin/directory_...
runtime/bin/directory_win.cc:241: printf("%s junction\n", dir_name);
Please remove debug print.

https://chromiumcodereview.appspot.com/10825413/diff/1/tests/standalone/io/di...
File tests/standalone/io/directory_test.dart (right):

https://chromiumcodereview.appspot.com/10825413/diff/1/tests/standalone/io/di...
tests/standalone/io/directory_test.dart:189: static void
testDeleteWindowsJunction() {
Shouldn't we make this test run with symlinks on Linux and Mac?

[Mads Ager (google), 2012-08-17 07:08:46]

https://chromiumcodereview.appspot.com/10825413/diff/1/runtime/bin/directory_...
File runtime/bin/directory_win.cc (right):

https://chromiumcodereview.appspot.com/10825413/diff/1/runtime/bin/directory_...
runtime/bin/directory_win.cc:241: printf("%s junction\n", dir_name);
Remove debug printing.

https://chromiumcodereview.appspot.com/10825413/diff/1/tests/standalone/io/di...
File tests/standalone/io/directory_test.dart (right):

https://chromiumcodereview.appspot.com/10825413/diff/1/tests/standalone/io/di...
tests/standalone/io/directory_test.dart:189: static void
testDeleteWindowsJunction() {
Does this test leave a temporary directory behind. We have to make sure that the
entire thing is deleted again at the end of the test.

https://chromiumcodereview.appspot.com/10825413/diff/1/tests/standalone/io/di...
tests/standalone/io/directory_test.dart:470: Future<File> writeFile(File file,
String contents) {
Where are you using this? Remove?

[Bob Nystrom, 2012-08-20 23:24:32]

Thanks for the feedback! Søren, I generalized the test to work on Mac/Linux like
you suggested (by invoking "ln" to create a symlink).

I'm going to go ahead and check this patch in to avoid having to wait through
another 24 hour review cycle because of the time difference, but if you aren't
OK with it, feel free to revert and let me know what else I can do. I think I've
addressed everything.

https://chromiumcodereview.appspot.com/10825413/diff/1/runtime/bin/directory_...
File runtime/bin/directory_win.cc (right):

https://chromiumcodereview.appspot.com/10825413/diff/1/runtime/bin/directory_...
runtime/bin/directory_win.cc:241: printf("%s junction\n", dir_name);
On 2012/08/17 07:08:46, Mads Ager wrote:
> Remove debug printing.

Done.

https://chromiumcodereview.appspot.com/10825413/diff/1/tests/standalone/io/di...
File tests/standalone/io/directory_test.dart (right):

https://chromiumcodereview.appspot.com/10825413/diff/1/tests/standalone/io/di...
tests/standalone/io/directory_test.dart:189: static void
testDeleteWindowsJunction() {
On 2012/08/17 07:08:46, Mads Ager wrote:
> Does this test leave a temporary directory behind. We have to make sure that
the
> entire thing is deleted again at the end of the test.

Done.

https://chromiumcodereview.appspot.com/10825413/diff/1/tests/standalone/io/di...
tests/standalone/io/directory_test.dart:189: static void
testDeleteWindowsJunction() {
On 2012/08/17 07:07:37, Søren Gjesse wrote:
> Shouldn't we make this test run with symlinks on Linux and Mac?

Done.

https://chromiumcodereview.appspot.com/10825413/diff/1/tests/standalone/io/di...
tests/standalone/io/directory_test.dart:470: Future<File> writeFile(File file,
String contents) {
On 2012/08/17 07:08:46, Mads Ager wrote:
> Where are you using this? Remove?

Done.

[Mads Ager (google), 2012-08-21 05:49:30]

LGTM!