Don't traverse through junctions when recursively deleting on Windows.

tests/standalone/io/directory_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Directory listing test.
 
 #import("dart:io");
 #import("dart:isolate");
 
 class DirectoryTest {
@@ skipping 168 matching lines @@
     buffer.add(subDir.path);
     for (var i = 0; i < 1000; i++) {
       buffer.add("/../${subDirName}");
     }
     var long = new Directory("${buffer.toString()}");
     Expect.throws(long.deleteSync);
     Expect.throws(() => long.deleteRecursivelySync());
     d.deleteRecursivelySync();
   }
 
+  static void testDeleteWindowsJunction() {

[Søren Gjesse, 2012/08/17 07:07:37]

Shouldn't we make this test run with symlinks on Linux and Mac?

[Mads Ager (google), 2012/08/17 07:08:46]

Does this test leave a temporary directory behind. We have to make sure that the
entire thing is deleted again at the end of the test.

[Bob Nystrom, 2012/08/20 23:24:32]

Done.

[Bob Nystrom, 2012/08/20 23:24:32]

Done.

+    if (Platform.operatingSystem != "windows") return;
+
+    // temp/
+    //   a/
+    //     file.txt
+    //   b/
+    //     a_junction -> a
+    var d = new Directory("").createTempSync();
+    new Directory("${d.path}\\a").createSync();
+
+    var b = new Directory("${d.path}\\b");
+    b.createSync();
+
+    var f = new File("${d.path}\\a\\file.txt");
+    f.createSync();
+    Expect.isTrue(f.existsSync());
+
+    // Create a junction from temp/b/a_junction -> temp/a.
+    var args =  ["/c", "mklink", "/j",
+        "${d.path}\\b\\a_junction", "${d.path}\\a"];
+    Process.run("cmd", args).then((_) {
+      // Delete the directory containing the junction.
+      b.deleteRecursivelySync();
+
+      // We should not have recursed through a_junction into a.
+      Expect.isTrue(f.existsSync());
+    });
+  }
+
   static void testExistsCreateDelete() {
     new Directory("").createTemp().then((d) {
       d.exists().then((bool exists) {
         Expect.isTrue(exists);
         Directory created = new Directory("${d.path}/subdir");
         created.create().then((ignore) {
           created.exists().then((bool exists) {
             Expect.isTrue(exists);
             created.delete().then((ignore) {
               created.exists().then((bool exists) {
@@ skipping 131 matching lines @@
   }
 
   static void testMain() {
     testListing();
     testListNonExistent();
     testListTooLongName();
     testDeleteNonExistent();
     testDeleteTooLongName();
     testDeleteNonExistentSync();
     testDeleteTooLongNameSync();
+    testDeleteWindowsJunction();
     testExistsCreateDelete();
     testExistsCreateDeleteSync();
     testCreateTemp();
     testCreateDeleteTemp();
     testCurrent();
     testFromPath();
   }
 }
 
 
@@ skipping 79 matching lines @@
   temp2.rename(temp1.path).then((temp4) {
     Expect.isFalse(temp3.existsSync());
     Expect.isFalse(temp2.existsSync());
     Expect.isTrue(temp1.existsSync());
     Expect.isTrue(temp4.existsSync());
     Expect.equals(temp1.path, temp4.path);
     temp1.deleteRecursivelySync();
   });
 }
 
+Future<File> writeFile(File file, String contents) {

[Mads Ager (google), 2012/08/17 07:08:46]

Where are you using this? Remove?

[Bob Nystrom, 2012/08/20 23:24:32]

Done.

+  return file.open(FileMode.WRITE).chain((opened) {
+    return opened.writeString(contents).chain((_) {
+      return opened.close().transform((ignore) => file);
+    });
+  });
+}
 
 main() {
   DirectoryTest.testMain();
   NestedTempDirectoryTest.testMain();
   testCreateTempErrorSync();
   testCreateTempError();
   testRename();
 }