Don't infer non-final field types

Don't infer non-final field types

We can not analyze universe and prove that field is not reassigned to have value of othe type.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=10260

[Brian Wilkerson, 2012-08-03 21:53:07]

LGTM

https://chromiumcodereview.appspot.com/10825190/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10825190/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2528: if
(node.getModifiers().isFinal()) {
You might also want to include const fields because they're implicitly final. I
don't think we accept them yet, but when we do this code won't need to be
updated.

https://chromiumcodereview.appspot.com/10825190/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractUtils.java
(right):

https://chromiumcodereview.appspot.com/10825190/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractUtils.java:394:
// XXX
Did you intend to include this in the CL? (No response required, just drawing
attention to it.)

[scheglov, 2012-08-03 22:08:20]

https://chromiumcodereview.appspot.com/10825190/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10825190/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2528: if
(node.getModifiers().isFinal()) {
On 2012/08/03 21:53:07, Brian Wilkerson wrote:
> You might also want to include const fields because they're implicitly final.
I
> don't think we accept them yet, but when we do this code won't need to be
> updated.

I've added tests for "const".
But actually we don't need to check for "const" separately, because every const
is marked as "final" in parser.

https://chromiumcodereview.appspot.com/10825190/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractUtils.java
(right):

https://chromiumcodereview.appspot.com/10825190/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractUtils.java:394:
// XXX
On 2012/08/03 21:53:07, Brian Wilkerson wrote:
> Did you intend to include this in the CL? (No response required, just drawing
> attention to it.)

Ah... Thank you!