editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractLocalRefactoring.java - Issue 10825190: Don't infer non-final field types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractLocalRefactoring.java

Issue 10825190: Don't infer non-final field types (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Tests for 'const' Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/SourceRangeFactory.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractMethodRefactoring.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractLocalRefactoring.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractLocalRefactoring.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractLocalRefactoring.java

index 0dedbd311ccf7cc9da66f2a17d6202bb66068054..001b523b951cc3d5caaa45e733e4d8b93843acfa 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractLocalRefactoring.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractLocalRefactoring.java

@@ -303,7 +303,7 @@ public class ExtractLocalRefactoring extends Refactoring {

List<SourceRange> occurrences = Lists.newArrayList();

// prepare selection

String selectionSource = utils.getText(selectionStart, selectionLength);

- List<com.google.dart.engine.scanner.Token> selectionTokens = ExtractUtils.tokenizeSource(selectionSource);

+ List<com.google.dart.engine.scanner.Token> selectionTokens = TokenUtils.getTokens(selectionSource);

selectionSource = StringUtils.join(selectionTokens, TOKEN_SEPARATOR);

// prepare enclosing function

com.google.dart.compiler.ast.DartFunction function;

@@ -319,7 +319,7 @@ public class ExtractLocalRefactoring extends Refactoring {

int functionOffset = functionSourceInfo.getOffset();

String functionSource = utils.getText(functionOffset, functionSourceInfo.getLength());

// prepare function tokens

- List<com.google.dart.engine.scanner.Token> functionTokens = ExtractUtils.tokenizeSource(functionSource);

+ List<com.google.dart.engine.scanner.Token> functionTokens = TokenUtils.getTokens(functionSource);

functionSource = StringUtils.join(functionTokens, TOKEN_SEPARATOR);

// find "selection" in "function" tokens

int lastIndex = 0;