Issue 10821012: Autogenerate additional arguments for fanky methods.

Issue 10821012: Autogenerate additional arguments for fanky methods. (Closed)

Created:
8 years, 5 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
podivilov, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Autogenerate additional arguments for fanky methods. Methods with CallWith=ScriptArguments|CallStack are declared w/o last argument in WebKit IDLs. Formerly this last argument was manually injected via dart.idl, but it's not robust in the presence of IDL modifications. TBR=podivilov@chromium.org,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=9890

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -49 lines)			Patch
M	lib/dom/dart2js/dom_dart2js.dart	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	lib/dom/dom.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/dom/idl/dart/dart.idl	View	1 chunk	+1 line, -21 lines	0 comments	Download
M	lib/dom/scripts/dartdomgenerator.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/dom/scripts/dartgenerator.py	View	1 chunk	+7 lines, -0 lines	2 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	4 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

https://chromiumcodereview.appspot.com/10821012/diff/1/lib/dom/scripts/dartgenerator.py File lib/dom/scripts/dartgenerator.py (right): https://chromiumcodereview.appspot.com/10821012/diff/1/lib/dom/scripts/dartgenerator.py#newcode288 lib/dom/scripts/dartgenerator.py:288: if operation.ext_attrs.get('CallWith') == 'ScriptArguments|CallStack': I thought we decided to ...

8 years, 4 months ago (2012-08-21 11:50:33 UTC) #2

Anton Muhin

8 years, 4 months ago (2012-08-21 12:03:37 UTC) #3

https://chromiumcodereview.appspot.com/10821012/diff/1/lib/dom/scripts/dartge...
File lib/dom/scripts/dartgenerator.py (right):

https://chromiumcodereview.appspot.com/10821012/diff/1/lib/dom/scripts/dartge...
lib/dom/scripts/dartgenerator.py:288: if operation.ext_attrs.get('CallWith') ==
'ScriptArguments|CallStack':
On 2012/08/21 11:50:34, podivilov wrote:
> I thought we decided to avoid patching the database to keep all the logic in
the
> same place. Why not just update the generators instead?

The problem is I failed to find the best place for it: this newly added argument
can participate in overloads, etc. if memory serves.  So to reuse most of our
machinery I took this shortcut.

We can revisit it, of course.

Expand Messages | Collapse Messages