Autogenerate additional arguments for fanky methods.

lib/dom/scripts/dartgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module generates Dart APIs from the IDL database."""
 
 import emitter
 import idlnode
 import logging
@@ skipping 263 matching lines @@
 
   def FixEventTargets(self, database):
     for interface in database.GetInterfaces():
       # Create fake EventTarget parent interface for interfaces that have
       # 'EventTarget' extended attribute.
       if 'EventTarget' in interface.ext_attrs:
         ast = [('Annotation', [('Id', 'WebKit')]),
                ('InterfaceType', ('ScopedName', 'EventTarget'))]
         interface.parents.append(idlnode.IDLParentInterface(ast))
 
+  def AddMissingArguments(self, database):
+    ARG = idlnode.IDLArgument([('Type', ('ScopedName', 'Object')), ('Id', 'arg')])
+    for interface in database.GetInterfaces():
+      for operation in interface.operations:
+        if operation.ext_attrs.get('CallWith') == 'ScriptArguments|CallStack':

[podivilov, 2012/08/21 11:50:34]

I thought we decided to avoid patching the database to keep all the logic in the
same place. Why not just update the generators instead?

[Anton Muhin, 2012/08/21 12:03:37]

The problem is I failed to find the best place for it: this newly added argument
can participate in overloads, etc. if memory serves.  So to reuse most of our
machinery I took this shortcut.

We can revisit it, of course.

+          operation.arguments.append(ARG)
+
 # ------------------------------------------------------------------------------
 
 class DummyImplementationSystem(systembase.System):
   """Generates a dummy implementation for use by the editor analysis.
 
   All the code comes from hand-written library files.
   """
 
   def __init__(self, options):
     super(DummyImplementationSystem, self).__init__(options)
@@ skipping 44 matching lines @@
         PARAMETERS=constructor_info.ParametersImplementationDeclaration(DartType))
 
   def FinishInterface(self):
     pass
 
   def AddTypedArrayConstructors(self, element_type):
     pass
 
   def AddEventAttributes(self, event_attrs):
     pass