Issue 10810043: Reenable GVN for fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10810043: Reenable GVN for fields. (Closed)

Created:
8 years, 5 months ago by floitsch

Modified:
8 years, 5 months ago

Reviewers:
ricow1, kasperl

CC:
reviews_dartlang.org, Mads Ager (google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reenable GVN for fields. GVN for fields was disabled in r9735 (issue 4086). Turns out that the fix was not too complicated. Committed: https://code.google.com/p/dart/source/detail?r=9801

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	lib/compiler/implementation/ssa/nodes.dart	View		2 chunks	+4 lines, -0 lines	1 comment	Download
	M	lib/compiler/implementation/ssa/optimize.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

https://chromiumcodereview.appspot.com/10810043/diff/1/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): https://chromiumcodereview.appspot.com/10810043/diff/1/lib/compiler/implementation/ssa/nodes.dart#newcode1309 lib/compiler/implementation/ssa/nodes.dart:1309: clearAllSideEffects(); The original version (when GVN was enabled) did ...

8 years, 5 months ago (2012-07-20 18:25:20 UTC) #1

ricow1

LGTM, for good measure you might want to change the description to say "was disabled ...

8 years, 5 months ago (2012-07-23 08:58:34 UTC) #3

floitsch

8 years, 5 months ago (2012-07-23 09:14:00 UTC) #4

On 2012/07/23 08:58:34, ricow1 wrote:
> LGTM, for good measure you might want to change the description to say "was
> disabled in r9735", 4086 was the bug.

done.

Expand Messages | Collapse Messages