Issue 10809095: Dump number of symbols in the isolate symbol table before shutting down an isolate under the --trac…

Issue 10809095: Dump number of symbols in the isolate symbol table before shutting down an isolate under the --trac… (Closed)

Created:
8 years, 5 months ago by siva

Modified:
8 years, 5 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Dump number of symbols in the isolate symbol table before shutting down an isolate under the --trace-isolates flag. Committed: https://code.google.com/p/dart/source/detail?r=9920

Patch Set 3 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
M	vm/isolate.cc	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	vm/symbols.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	vm/symbols.cc	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cshapiro

lgtm https://chromiumcodereview.appspot.com/10809095/diff/5001/vm/symbols.cc File vm/symbols.cc (right): https://chromiumcodereview.appspot.com/10809095/diff/5001/vm/symbols.cc#newcode50 vm/symbols.cc:50: intptr_t Symbols::UsedCount(Isolate* isolate) { Naming this method Size ...

8 years, 5 months ago (2012-07-25 02:57:20 UTC) #2

siva

8 years, 5 months ago (2012-07-25 23:41:15 UTC) #3

https://chromiumcodereview.appspot.com/10809095/diff/5001/vm/symbols.cc
File vm/symbols.cc (right):

https://chromiumcodereview.appspot.com/10809095/diff/5001/vm/symbols.cc#newco...
vm/symbols.cc:50: intptr_t Symbols::UsedCount(Isolate* isolate) {
I called the method 'Size' as it is a count of entries in the table and I
renamed the variable name table_size_index (index in which we store the table
size)

On 2012/07/25 02:57:20, cshapiro wrote:
> Naming this method Size and renaming the variable table_size to capacity would
> make things slightly more consistent with other ADTs in the VM (and elsewhere,
> too).

https://chromiumcodereview.appspot.com/10809095/diff/5001/vm/symbols.h
File vm/symbols.h (right):

https://chromiumcodereview.appspot.com/10809095/diff/5001/vm/symbols.h#newcode33
vm/symbols.h:33: // Get number of symbols in the isolate symbol table.
On 2012/07/25 02:57:20, cshapiro wrote:
> The use of a definite article threw me off a little.  It is consistent with
the
> preceding comment but an indefinite article might be better (such as "an
> isolate's symbol table").

Done.

Expand Messages | Collapse Messages