Dump number of symbols in the isolate symbol table before shutting down an isolate under the --trac…

vm/symbols.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_SYMBOLS_H_
 #define VM_SYMBOLS_H_
 
 #include "vm/object.h"
 
 namespace dart {
@@ skipping 12 matching lines @@
 
   // Access methods for symbols stored in the vm isolate.
   static RawString* Dot() { return dot_; }
 
   // Initialize frequently used symbols in the vm isolate.
   static void InitOnce(Isolate* isolate);
 
   // Initialize and setup a symbol table for the isolate.
   static void SetupSymbolTable(Isolate* isolate);
 
+  // Get number of symbols in the isolate symbol table.

[cshapiro, 2012/07/25 02:57:20]

The use of a definite article threw me off a little.  It is consistent with the
preceding comment but an indefinite article might be better (such as "an
isolate's symbol table").

[siva, 2012/07/25 23:41:15]

Done.

+  static intptr_t UsedCount(Isolate* isolate);
+
   // Helper functions to create a symbol given a string or set of characters.
   static RawString* New(const char* str);
   template<typename T>
   static RawString* New(const T* characters, intptr_t len);
   static RawString* New(const String& str);
   static RawString* New(const String& str,
                         intptr_t begin_index,
                         intptr_t length);
 
 
@@ skipping 28 matching lines @@
   static RawString* dot_;  // "." string.
 
   friend class SnapshotReader;
 
   DISALLOW_COPY_AND_ASSIGN(Symbols);
 };
 
 }  // namespace dart
 
 #endif  // VM_SYMBOLS_H_