Issue 10808064: Rename some of the enum definitions inside classes to avoid conflict with the ObjectKind enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10808064: Rename some of the enum definitions inside classes to avoid conflict with the ObjectKind enum. (Closed)

Created:
8 years, 5 months ago by siva

Modified:
8 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Rename some of the enum definitions inside classes to avoid conflict with the ObjectKind enum. Committed: https://code.google.com/p/dart/source/detail?r=9792

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -58 lines)			Patch
M	vm/bootstrap.cc	View	1 2	5 chunks	+5 lines, -5 lines	0 comments	Download
M	vm/code_descriptors_test.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/code_generator_test.cc	View	1 2	3 chunks	+9 lines, -3 lines	0 comments	Download
M	vm/code_patcher_ia32_test.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/code_patcher_x64_test.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/compiler_test.cc	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	vm/dart_api_impl.cc	View	1 2	5 chunks	+7 lines, -6 lines	0 comments	Download
M	vm/dart_entry_test.cc	View	1 2	3 chunks	+9 lines, -3 lines	0 comments	Download
M	vm/find_code_object_test.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	vm/object.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	vm/object.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	vm/object_test.cc	View	1 2	6 chunks	+12 lines, -10 lines	0 comments	Download
M	vm/parser.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	vm/parser.cc	View	1 2	6 chunks	+6 lines, -6 lines	0 comments	Download
M	vm/parser_test.cc	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	vm/raw_object.h	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	vm/resolver_test.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	vm/runtime_entry_test.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/snapshot.h	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	vm/snapshot_test.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	vm/stub_code_ia32_test.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/stub_code_x64_test.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/unit_test.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages