Issue 10806047: Fix crash during parallel moves.

Issue 10806047: Fix crash during parallel moves. (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix crash during parallel moves. Made MoveOperands ZoneAlloacted. Non-const ValueObjects a fragile, since it is easy to modify a copy instead of the original. It is also dangereous to use pointers to ValueObjects that contain copy constructors. Committed: https://code.google.com/p/dart/source/detail?r=9790

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Total comments: 2

Patch Set 12 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -66 lines)			Patch
M	runtime/vm/flow_graph_allocator.cc	View	1 2 3 4 5 6 7 8	2 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 2 3 4 5 6 7 8 9	6 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3 4 5 6 7 8	2 chunks	+11 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3 4 5 6 7 8 9	3 chunks	+12 lines, -10 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4 5 6 7 8 9 10 11	4 chunks	+13 lines, -6 lines	0 comments	Download
M	runtime/vm/locations.h	View	1 2 3 4 5 6 7 8	2 chunks	+2 lines, -13 lines	0 comments	Download
M	runtime/vm/locations.cc	View	1 2 3 4 5 6 7 8	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10806047/diff/9004/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10806047/diff/9004/runtime/vm/intermediate_language.h#newcode2382 runtime/vm/intermediate_language.h:2382: // This class is often passed by value. ...

8 years, 5 months ago (2012-07-20 21:11:25 UTC) #2

srdjan

8 years, 5 months ago (2012-07-20 21:15:47 UTC) #3

Thanks.

https://chromiumcodereview.appspot.com/10806047/diff/9004/runtime/vm/intermed...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10806047/diff/9004/runtime/vm/intermed...
runtime/vm/intermediate_language.h:2382: // This class is often passed by value.
Add additional fields with caution.
On 2012/07/20 21:11:25, regis wrote:
> This comment is not true anymore.

Removed

Expand Messages | Collapse Messages