Fix crash during parallel moves.

runtime/vm/flow_graph_compiler_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
@@ skipping 27 matching lines @@
   } else {
     // We have a deoptimization environment, we have to tear down optimized
     // frame and recreate non-optimized one.
     __ leaq(RSP,
             Address(RBP, ParsedFunction::kFirstLocalSlotIndex * kWordSize));
 
     const GrowableArray<Value*>& values = deoptimization_env_->values();
     const GrowableArray<Location>* locations = deoptimization_env_->locations();
 
     for (intptr_t i = 0; i < values.length(); i++) {
-      Location loc = (*locations)[i];
+      const Location loc = (*locations)[i];
       if (loc.IsInvalid()) {
         ASSERT(values[i]->IsConstant());
         __ PushObject(values[i]->AsConstant()->value());
       } else {
         ASSERT(loc.IsRegister());
         __ pushq(loc.reg());
       }
     }
   }
 
@@ skipping 1047 matching lines @@
   __ cvtsi2sd(result, temp);
   __ Bind(&done);
 }
 
 
 #undef __
 #define __ compiler_->assembler()->
 
 
 void ParallelMoveResolver::EmitMove(int index) {
-  Location source = moves_[index].src();
-  Location destination = moves_[index].dest();
+  MoveOperands* move = moves_[index];
+  const Location source = move->src();
+  const Location destination = move->dest();
 
   ASSERT(destination.IsRegister());
   if (source.IsRegister()) {
     __ movq(destination.reg(), source.reg());
   } else {
     ASSERT(source.IsConstant());
     __ LoadObject(destination.reg(), source.constant());
   }
-  moves_[index].Eliminate();
+  move->Eliminate();
 }
 
 
 void ParallelMoveResolver::EmitSwap(int index) {
-  Location source = moves_[index].src();
-  Location destination = moves_[index].dest();
+  MoveOperands* move = moves_[index];
+  const Location source = move->src();
+  const Location destination = move->dest();
 
   ASSERT(source.IsRegister() && destination.IsRegister());
   __ xchgq(destination.reg(), source.reg());
 
   // The swap of source and destination has executed a move from source to
   // destination.
-  moves_[index].Eliminate();
+  move->Eliminate();
 
   // Any unperformed (including pending) move with a source of either
   // this move's source or destination needs to have their source
   // changed to reflect the state of affairs after the swap.
   for (int i = 0; i < moves_.length(); ++i) {
-    MoveOperands other_move = moves_[i];
+    const MoveOperands& other_move = *moves_[i];
     if (other_move.Blocks(source)) {
-      moves_[i].set_src(destination);
+      moves_[i]->set_src(destination);
     } else if (other_move.Blocks(destination)) {
-      moves_[i].set_src(source);
+      moves_[i]->set_src(source);
     }
   }
 }
 
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64