Issue 10800065: Added ClosureMirror to dart:mirrors. Added Dart_ClosureFunction to the

Issue 10800065: Added ClosureMirror to dart:mirrors. Added Dart_ClosureFunction to the (Closed)

Created:
8 years, 5 months ago by rmacnak

Modified:
8 years, 5 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added ClosureMirror to dart:mirrors. Added Dart_ClosureFunction to the embedding API. ClosureMirrors currently implement answering the closure's function and applying the closure. Committed: https://code.google.com/p/dart/source/detail?r=9860

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -3 lines)			Patch
M	lib/mirrors/mirrors.dart	View	1 2 3	1 chunk	+32 lines, -0 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/lib/mirrors.cc	View	1 2 3	5 chunks	+53 lines, -3 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1 2 3	1 chunk	+49 lines, -0 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2 3	1 chunk	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2 3	1 chunk	+35 lines, -0 lines	0 comments	Download
M	tests/lib/mirrors/mirrors_test.dart	View	1 2 3	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://chromiumcodereview.appspot.com/10800065/diff/5001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://chromiumcodereview.appspot.com/10800065/diff/5001/runtime/lib/mirrors.cc#newcode711 runtime/lib/mirrors.cc:711: // We set the function field of ClosureMirrors outside ...

8 years, 5 months ago (2012-07-23 23:57:20 UTC) #2

rmacnak

Made ClosureMirrorImpl implement ClosureMirror. Added tests for the mirror library part of ClosureMirror (as opposed ...

8 years, 5 months ago (2012-07-24 01:13:59 UTC) #3

LGTM -ip

Expand Messages | Collapse Messages