Added ClosureMirror to dart:mirrors. Added Dart_ClosureFunction to the

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
 
 // These values are allowed to be passed directly over the wire.
 bool isSimpleValue(var value) {
   return (value === null || value is num || value is String || value is bool);
 }
@@ skipping 194 matching lines @@
         return "InstanceMirror on <'${_dartEscape(_reflectee)}'>";
       } else {
         return "InstanceMirror on <$_reflectee>";
       }
     } else {
       return "InstanceMirror on instance of '${getClass().simpleName}'";
     }
   }
 }
 
+class _LocalClosureMirrorImpl extends _LocalInstanceMirrorImpl
+    implements InstanceMirror {

[Ivan Posva, 2012/07/23 23:57:20]

Should implement ClosureMirror here.

+  _LocalClosureMirrorImpl(ref,
+                          klass,
+                          reflectee) : super(ref, klass, reflectee) {}
+
+  MethodMirror _function;
+  MethodMirror function() => _function;
+
+  String source() {
+    throw "asYetUnimplemented";

[Ivan Posva, 2012/07/23 23:57:20]

See other uses of "throw new NotImplementedException(...)". For example in your
code below.

+  }
+
+  Future<ObjectMirror> apply(List<Object> positionalArguments,
+                             [Map<String,Object> namedArguments]) {
+    if (namedArguments !== null) {
+      throw new NotImplementedException('named arguments not implemented');
+    }
+    // Walk the arguments and make sure they are legal.
+    for (int i = 0; i < positionalArguments.length; i++) {
+      var arg = positionalArguments[i];
+      if (arg is Mirror) {
+        if (arg is! InstanceMirror) {
+          throw new MirrorException(
+              'positional argument $i ($arg) was not an InstanceMirror');
+        }
+      } else if (!isSimpleValue(arg)) {
+        throw new MirrorException(
+            'positional argument $i ($arg) was not a simple value');
+      }
+    }
+    Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
+    try {
+      completer.complete(
+          _apply(this, positionalArguments));
+    } catch (var exception) {
+      completer.completeException(exception);
+    }
+    return completer.future;
+  }
+
+  Future<ObjectMirror> findInContext(String name) {
+    throw "asYetUnimplemented";
+  }
+
+  static _apply(ref, positionalArguments)

[Ivan Posva, 2012/07/23 23:57:20]

Why is this native method marked as a static method?

[rmacnak, 2012/07/24 01:14:00]

Consistency with ObjectMirror's _invoke.

On 2012/07/23 23:57:20, Ivan Posva wrote:

+      native 'LocalClosureMirrorImpl_apply';
+}
+
 class _LazyInterfaceMirror {
   _LazyInterfaceMirror(this.libraryName, this.interfaceName) {}
 
   InterfaceMirror resolve(MirrorSystem mirrors) {
     if (libraryName === null) {
       if (interfaceName == 'Dynamic') {
         return mirrors._dynamicMirror();
       } else if (interfaceName == 'void') {
         return mirrors._dynamicMirror();
       } else {
@@ skipping 272 matching lines @@
 
   // Creates a new local InstanceMirror
   static InstanceMirror makeLocalInstanceMirror(Object reflectee)
       native 'Mirrors_makeLocalInstanceMirror';
 
   // Creates a new local mirror for some Object.
   static InstanceMirror mirrorOf(Object reflectee) {
     return makeLocalInstanceMirror(reflectee);
   }
 }