Issue 10796103: Use kIllegalObjectKind instead of NULL object to terminate ICData array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10796103: Use kIllegalObjectKind instead of NULL object to terminate ICData array (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use kIllegalObjectKind instead of NULL object to terminate ICData array Committed: https://code.google.com/p/dart/source/detail?r=9835

Patch Set 6 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -19 lines)			Patch
M	runtime/vm/object.h	View	1 2	3 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 4	3 chunks	+17 lines, -8 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/10796103/diff/5001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://chromiumcodereview.appspot.com/10796103/diff/5001/runtime/vm/object.cc#newcode7209 runtime/vm/object.cc:7209: const Array& data = Array::Handle(ic_data()); const Smi& sentinel_value ...

8 years, 5 months ago (2012-07-24 00:14:06 UTC) #2

srdjan

8 years, 5 months ago (2012-07-24 00:25:31 UTC) #3

https://chromiumcodereview.appspot.com/10796103/diff/5001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10796103/diff/5001/runtime/vm/object.c...
runtime/vm/object.cc:7209: const Array& data = Array::Handle(ic_data());
On 2012/07/24 00:14:06, asiva wrote:
> const Smi& sentinel_value = Smi::Handle(Smi::New(kIllegalObjectKind));

Done.

https://chromiumcodereview.appspot.com/10796103/diff/5001/runtime/vm/object.c...
runtime/vm/object.cc:7211: data.SetAt(data.Length() - i,
Smi::Handle(Smi::New(kIllegalObjectKind)));
On 2012/07/24 00:14:06, asiva wrote:
> data.SetAt(data.Length() - i, sentinel_value);

Done.

Expand Messages | Collapse Messages

Issue 10796103: Use kIllegalObjectKind instead of NULL object to terminate ICData array (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Messages