Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: runtime/vm/object.h

Issue 10796103: Use kIllegalObjectKind instead of NULL object to terminate ICData array (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 9834)
+++ runtime/vm/object.h (working copy)
@@ -2650,7 +2650,7 @@
// Object holding information about an IC: test classes and their
-// corresponding classes.
+// corresponding targets.
class ICData : public Object {
public:
RawFunction* function() const {
@@ -2692,11 +2692,11 @@
}
// Adds one more class test to ICData. Length of 'classes' must be equal to
- // the number of arguments tested. Use only for number_of_checks > 1.
+ // the number of arguments tested. Use only for num_args_tested > 1.
void AddCheck(const GrowableArray<intptr_t>& class_ids,
const Function& target) const;
// Adds sorted so that Smi is the first class-id. Use only for
- // number_of_checks == 1.
+ // num_args_tested == 1.
void AddReceiverCheck(intptr_t receiver_class_id,
const Function& target) const;
void GetCheckAt(intptr_t index,
@@ -2730,6 +2730,7 @@
void set_ic_data(const Array& value) const;
intptr_t TestEntryLength() const;
+ void WriteSentinel() const;
HEAP_OBJECT_IMPLEMENTATION(ICData, Object);
friend class Class;
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698