Issue 10795076: Fix 4182: When inlining StringBase_get_length, we cannot assume that all receivers where subclasse…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10795076: Fix 4182: When inlining StringBase_get_length, we cannot assume that all receivers where subclasse… (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 4182: When inlining StringBase_get_length, we cannot assume that all receivers where subclasses of StringBase since we are running in production mode. Committed: https://code.google.com/p/dart/source/detail?r=9829

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with one question. https://chromiumcodereview.appspot.com/10795076/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://chromiumcodereview.appspot.com/10795076/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode301 runtime/vm/flow_graph_optimizer.cc:301: // All bets are off ...

8 years, 5 months ago (2012-07-23 21:38:57 UTC) #2

srdjan

8 years, 5 months ago (2012-07-23 21:40:41 UTC) #3

https://chromiumcodereview.appspot.com/10795076/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10795076/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_optimizer.cc:301: // All bets are off if we run in
production mode, i.e., at one call site
On 2012/07/23 21:38:57, regis wrote:
> "if we run in production mode"
> Can you do more if we run in checked mode?
> The comment is not clear.

Changed comment: it can happen in any mode. Just saying this is not
StringBase_get_length if there are multiple targets.

Expand Messages | Collapse Messages