runtime/vm/flow_graph_optimizer.cc - Issue 10795076: Fix 4182: When inlining StringBase_get_length, we cannot assume that all receivers where subclasse…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 10795076: Fix 4182: When inlining StringBase_get_length, we cannot assume that all receivers where subclasse… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 9826)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -298,6 +298,10 @@

}

if (recognized_kind == MethodRecognizer::kStringBaseLength) {

+ if (!HasOneTarget(ic_data)) {

+ // Target is not only StringBase_get_length.

+ return false;

+ }

ASSERT(HasOneTarget(ic_data));

LoadVMFieldComp* load = new LoadVMFieldComp(

comp->InputAt(0),

« no previous file with comments | « no previous file | no next file » | no next file with comments »