Issue 10792019: Address some leftover review comments from previous CL.

Issue 10792019: Address some leftover review comments from previous CL. (Closed)

Created:
8 years, 5 months ago by siva

Modified:
8 years, 5 months ago

Reviewers:
cshapiro, sra1

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Address some leftover review comments from previous CL. Committed: https://code.google.com/p/dart/source/detail?r=9721

Patch Set 4 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -41 lines)			Patch
M	vm/object.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	vm/os.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	vm/os_linux.cc	View	1 2 3	1 chunk	+9 lines, -13 lines	0 comments	Download
M	vm/os_macos.cc	View	1 2 3	1 chunk	+9 lines, -13 lines	0 comments	Download
M	vm/os_win.cc	View	1 2 3	1 chunk	+9 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

cshapiro

https://chromiumcodereview.appspot.com/10792019/diff/8/vm/os_linux.cc File vm/os_linux.cc (right): https://chromiumcodereview.appspot.com/10792019/diff/8/vm/os_linux.cc#newcode164 vm/os_linux.cc:164: bool OS::StringToInt64(const char* str, int64_t* value) { Much better ...

8 years, 5 months ago (2012-07-17 18:02:23 UTC) #4

siva

8 years, 5 months ago (2012-07-17 20:59:49 UTC) #5

https://chromiumcodereview.appspot.com/10792019/diff/8/vm/os_linux.cc
File vm/os_linux.cc (right):

https://chromiumcodereview.appspot.com/10792019/diff/8/vm/os_linux.cc#newcode164
vm/os_linux.cc:164: bool OS::StringToInt64(const char* str, int64_t* value) {
Anything to keep you happy  :-)

On 2012/07/17 18:02:23, cshapiro wrote:
> Much better name, thank you!

https://chromiumcodereview.appspot.com/10792019/diff/8/vm/os_linux.cc#newcode179
vm/os_linux.cc:179: if (errno != 0 || endptr == str || *endptr != 0) {
it would be
return !(errno != 0 || endptr == str || *endptr != 0);

or
return (errno == 0 && endptr != str && *endptr == 0);
On 2012/07/17 18:02:23, cshapiro wrote:
> You could just return the result of the disjunction
> 
>   return (errno != 0 || endptr == str || *endptr != 0);

Expand Messages | Collapse Messages