Address some leftover review comments from previous CL.

vm/os_linux.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/os.h"
 
 #include <errno.h>
 #include <limits.h>
 #include <time.h>
 #include <sys/resource.h>
@@ skipping 143 matching lines @@
 
 int OS::VSNPrint(char* str, size_t size, const char* format, va_list args) {
   int retval = vsnprintf(str, size, format, args);
   if (retval < 0) {
     FATAL1("Fatal error in OS::VSNPrint with format '%s'", format);
   }
   return retval;
 }
 
 
-bool OS::StringToInteger(const char* str, int64_t* value) {
+bool OS::StringToInt64(const char* str, int64_t* value) {

[cshapiro, 2012/07/17 18:02:23]

Much better name, thank you!

[siva, 2012/07/17 20:59:49]

Anything to keep you happy  :-)

On 2012/07/17 18:02:23, cshapiro wrote:

   ASSERT(str != NULL && strlen(str) > 0 && value != NULL);
-  bool negative_value = false;
   int32_t base = 10;
+  char* endptr;
+  int i = 0;
   if (str[0] == '-') {
-    negative_value = true;
-    str += 1;
+    i = 1;
   }
-  if ((str[0] == '0') && (str[1] == 'x' || str[1] == 'X') && (str[2] != '\0')) {
+  if ((str[i] == '0') &&
+      (str[i + 1] == 'x' || str[i + 1] == 'X') &&
+      (str[i + 2] != '\0')) {
     base = 16;
   }
   errno = 0;
-  *value = strtoll(str, NULL, base);
-  if (errno == 0) {
-    if (negative_value) {
-      *value = -(*value);
-    }
-    return true;
+  *value = strtoll(str, &endptr, base);
+  if (errno != 0 || endptr == str || *endptr != 0) {

[cshapiro, 2012/07/17 18:02:23]

You could just return the result of the disjunction

  return (errno != 0 || endptr == str || *endptr != 0);

[siva, 2012/07/17 20:59:49]

it would be
return !(errno != 0 || endptr == str || *endptr != 0);

or
return (errno == 0 && endptr != str && *endptr == 0);
On 2012/07/17 18:02:23, cshapiro wrote:

+    return false;
   }
-  return false;
+  return true;
 }
 
 
 void OS::PrintErr(const char* format, ...) {
   va_list args;
   va_start(args, format);
   VFPrint(stderr, format, args);
   va_end(args);
 }
 
@@ skipping 15 matching lines @@
 void OS::Abort() {
   abort();
 }
 
 
 void OS::Exit(int code) {
   exit(code);
 }
 
 }  // namespace dart