Issue 10786003: Ensure objects emitted in code are allocated in old space.

Issue 10786003: Ensure objects emitted in code are allocated in old space. (Closed)

Created:
8 years, 5 months ago by cshapiro

Modified:
8 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ensure objects emitted in code are allocated in old space. BUG=3866 Committed: https://code.google.com/p/dart/source/detail?r=9649

Patch Set 2 : address review comments #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -53 lines)			Patch
M	runtime/vm/assembler.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/ast.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/bigint_operations.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/code_generator_test.cc	View		4 chunks	+11 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	7 chunks	+79 lines, -35 lines	0 comments	Download
M	runtime/vm/object_ia32_test.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/object_x64_test.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_ia32_test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_x64_test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM!! http://codereview.chromium.org/10786003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): http://codereview.chromium.org/10786003/diff/1/runtime/vm/object.cc#newcode2797 runtime/vm/object.cc:2797: // TODO(srdjan): Copy type into old space if ...

8 years, 5 months ago (2012-07-13 22:32:16 UTC) #2

cshapiro

8 years, 5 months ago (2012-07-13 23:16:59 UTC) #3

http://codereview.chromium.org/10786003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/10786003/diff/1/runtime/vm/object.cc#newcode2797
runtime/vm/object.cc:2797: // TODO(srdjan): Copy type into old space if
canonicalized?
Yes!  Done.

http://codereview.chromium.org/10786003/diff/1/runtime/vm/object.cc#newcode3460
runtime/vm/object.cc:3460: // TODO(srdjan): Copy 'this' into old space if
canonicalized?
Done.  Both, actually.  Running the test with checked mode turned on required
that the type argument be canonized.

http://codereview.chromium.org/10786003/diff/1/runtime/vm/object.cc#newcode7608
runtime/vm/object.cc:7608: // TODO(srdjan): Copy instance into old space if
canonicalized?
Done.

Expand Messages | Collapse Messages