runtime/vm/flow_graph_compiler_ia32.cc - Issue 10786003: Ensure objects emitted in code are allocated in old space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 10786003: Ensure objects emitted in code are allocated in old space. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address review comments Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc

index 532725591b6816a8a93ec468101ecb817be76182..1e67f813bf2fc221f2715d3a22eec60c91134381 100644

--- a/runtime/vm/flow_graph_compiler_ia32.cc

+++ b/runtime/vm/flow_graph_compiler_ia32.cc

@@ -742,6 +742,7 @@ void FlowGraphCompiler::CopyParameters() {

__ j(GREATER, &next_parameter, Assembler::kNearJump);

// Check if this named parameter was passed in.

__ movl(EAX, Address(EDI, 0)); // Load EAX with the name of the argument.

+ ASSERT(opt_param[i]->name().IsSymbol());

__ CompareObject(EAX, opt_param[i]->name());

__ j(NOT_EQUAL, &load_default_value, Assembler::kNearJump);

// Load EAX with passed-in argument at provided arg_pos, i.e. at

« no previous file with comments | « runtime/vm/code_generator_test.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »