Issue 10753018: Intrinsify a couple of x64 methods (fix performance regression on Mandelbrot). Need to investigate …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10753018: Intrinsify a couple of x64 methods (fix performance regression on Mandelbrot). Need to investigate … (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Intrinsify a couple of x64 methods (fix performance regression on Mandelbrot). Need to investigate Mandelbrot optimization next. Committed: https://code.google.com/p/dart/source/detail?r=9495

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -5 lines)			Patch
	M	runtime/vm/intrinsifier_x64.cc	View	1	2 chunks	+32 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/10753018/diff/1/runtime/vm/intrinsifier_x64.cc File runtime/vm/intrinsifier_x64.cc (right): https://chromiumcodereview.appspot.com/10753018/diff/1/runtime/vm/intrinsifier_x64.cc#newcode499 runtime/vm/intrinsifier_x64.cc:499: TestBothArgumentsSmis(assembler, &fall_through); probably document // RAX contains .... ...

8 years, 5 months ago (2012-07-10 01:03:00 UTC) #2

srdjan

8 years, 5 months ago (2012-07-10 01:11:28 UTC) #3

https://chromiumcodereview.appspot.com/10753018/diff/1/runtime/vm/intrinsifie...
File runtime/vm/intrinsifier_x64.cc (right):

https://chromiumcodereview.appspot.com/10753018/diff/1/runtime/vm/intrinsifie...
runtime/vm/intrinsifier_x64.cc:499: TestBothArgumentsSmis(assembler,
&fall_through);
On 2012/07/10 01:03:00, asiva wrote:
> probably document
> // RAX contains ....
> like the documentation in CompareIntegers

Done.

Expand Messages | Collapse Messages

Issue 10753018: Intrinsify a couple of x64 methods (fix performance regression on Mandelbrot). Need to investigate … (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages