Intrinsify a couple of x64 methods (fix performance regression on Mandelbrot). Need to investigate …

runtime/vm/intrinsifier_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
@@ skipping 477 matching lines @@
   return false;
 }
 
 
 bool Intrinsifier::Integer_add(Assembler* assembler) {
   return false;
 }
 
 
 bool Intrinsifier::Integer_subFromInteger(Assembler* assembler) {
+  Label fall_through;
+  TestBothArgumentsSmis(assembler, &fall_through);

[siva, 2012/07/10 01:03:00]

probably document
// RAX contains ....
like the documentation in CompareIntegers

[srdjan, 2012/07/10 01:11:29]

Done.

+  __ subq(RAX, Address(RSP, + 2 * kWordSize));
+  __ j(OVERFLOW, &fall_through, Assembler::kNearJump);
+  // Result is in RAX.
+  __ ret();
+  __ Bind(&fall_through);
   return false;
 }
 
 
 bool Intrinsifier::Integer_sub(Assembler* assembler) {
   return false;
 }
 
 
 
@@ skipping 79 matching lines @@
 bool Intrinsifier::Integer_bitXor(Assembler* assembler) {
   return false;
 }
 
 
 bool Intrinsifier::Integer_shl(Assembler* assembler) {
   return false;
 }
 
 
-bool Intrinsifier::Integer_lessThan(Assembler* assembler) {
+static bool CompareIntegers(Assembler* assembler, Condition true_condition) {
+  Label fall_through, true_label;
+  const Bool& bool_true = Bool::ZoneHandle(Bool::True());
+  const Bool& bool_false = Bool::ZoneHandle(Bool::False());
+  TestBothArgumentsSmis(assembler, &fall_through);
+  // RAX contains the right argument.
+  __ cmpq(Address(RSP, + 2 * kWordSize), RAX);
+  __ j(true_condition, &true_label, Assembler::kNearJump);
+  __ LoadObject(RAX, bool_false);
+  __ ret();
+  __ Bind(&true_label);
+  __ LoadObject(RAX, bool_true);
+  __ ret();
+  __ Bind(&fall_through);
   return false;
 }
 
 
+
+bool Intrinsifier::Integer_lessThan(Assembler* assembler) {
+  return CompareIntegers(assembler, LESS);
+}
+
+
 bool Intrinsifier::Integer_greaterThanFromInt(Assembler* assembler) {
-  return false;
+  return CompareIntegers(assembler, LESS);
 }
 
 
 bool Intrinsifier::Integer_greaterThan(Assembler* assembler) {
-  return false;
+  return CompareIntegers(assembler, GREATER);
 }
 
 
 bool Intrinsifier::Integer_lessEqualThan(Assembler* assembler) {
-  return false;
+  return CompareIntegers(assembler, LESS_EQUAL);
 }
 
 
 bool Intrinsifier::Integer_greaterEqualThan(Assembler* assembler) {
-  return false;
+  return CompareIntegers(assembler, GREATER_EQUAL);
 }
 
 
 bool Intrinsifier::Integer_equalToInteger(Assembler* assembler) {
   return false;
 }
 
 
 bool Intrinsifier::Integer_equal(Assembler* assembler) {
   return false;
@@ skipping 143 matching lines @@
 
 bool Intrinsifier::String_isEmpty(Assembler* assembler) {
   return false;
 }
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64