Issue 10704156: Bring back most of the performance lost when fixing union on types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704156: Bring back most of the performance lost when fixing union on types. (Closed)

Created:
8 years, 5 months ago by Mads Ager (google)

Modified:
8 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Bring back most of the performance lost when fixing union on types. We lost the basic propagation of known field types from constructors. R=floitsch@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9548

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -18 lines)			Patch
	M	lib/compiler/implementation/ssa/optimize.dart	View	1	1 chunk	+34 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/10704156/diff/1/lib/compiler/implementation/ssa/optimize.dart File lib/compiler/implementation/ssa/optimize.dart (right): https://chromiumcodereview.appspot.com/10704156/diff/1/lib/compiler/implementation/ssa/optimize.dart#newcode1192 lib/compiler/implementation/ssa/optimize.dart:1192: // If there are no other field setters ...

8 years, 5 months ago (2012-07-11 12:15:31 UTC) #2

Mads Ager (google)

8 years, 5 months ago (2012-07-11 12:31:20 UTC) #3

https://chromiumcodereview.appspot.com/10704156/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/10704156/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:1192: // If there are no other
field setters then the one in
On 2012/07/11 12:15:31, floitsch wrote:
> maybe assert, that we are not in the constructor body?

Good point. Done.

https://chromiumcodereview.appspot.com/10704156/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:1204: // guarenteed to remain
constant.
On 2012/07/11 12:15:31, floitsch wrote:
> If there are no setters then the initializer list type is
> guar*a*nteed to remain constant.

Whooops, done!

Expand Messages | Collapse Messages