Bring back most of the performance lost when fixing union on types.

lib/compiler/implementation/ssa/optimize.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface OptimizationPhase {
   String get name();
   void visitGraph(HGraph graph);
 }
 
 class SsaOptimizerTask extends CompilerTask {
@@ skipping 1157 matching lines @@
 
   void visitGraph(HGraph visitee) {
     graph = visitee;
     visitDominatorTree(visitee);
   }
 
   void visitFieldGet(HFieldGet node) {
     if (!node.element.enclosingElement.isClass()) return;
     Element field = node.element;
     HType type = backend.optimisticFieldTypeAfterConstruction(field);
-    if (!type.isConflicting() && !type.isUnknown()) {
+    if (!type.isUnknown()) {
       switch (compiler.phase) {
         case Compiler.PHASE_COMPILING:
+          // Recompile even if we haven't seen any types for this
+          // field yet. There might still be only one setter in an
+          // initializer list or constructor body.
           compiler.enqueuer.codegen.registerRecompilationCandidate(
               work.element);
           break;
         case Compiler.PHASE_RECOMPILING:
-          // Check if optimistic type is based on a setter in the constructor
-          // body.
-          if (backend.hasConstructorBodyFieldSetter(field)) {
-            // There is at least one field setter from the constructor.
-            if (!compiler.codegenWorld.hasInvokedSetter(field, compiler)) {
-              node.guaranteedType =
-                  type.union(backend.fieldSettersTypeSoFar(node.element));
+          if (!type.isConflicting()) {
+            // Check if optimistic type is based on a setter in the
+            // constructor body.
+            if (backend.hasConstructorBodyFieldSetter(field)) {
+              // If there are no other field setters then the one in

[floitsch, 2012/07/11 12:15:31]

maybe assert, that we are not in the constructor body?

[Mads Ager (google), 2012/07/11 12:31:20]

Good point. Done.

+              // the constructor body, the type is guaranteed for this
+              // field after construction.
+              if (!compiler.codegenWorld.hasInvokedSetter(field, compiler)) {
+                node.guaranteedType =
+                    type.union(backend.fieldSettersTypeSoFar(node.element));
+              } else {
+                node.propagatedType =
+                    type.union(backend.fieldSettersTypeSoFar(node.element));
+              }
             } else {
-              node.propagatedType =
-                  type.union(backend.fieldSettersTypeSoFar(node.element));
-            }
-          } else {
-            // Optimistic type is based on field initializer list.
-            if (!compiler.codegenWorld.hasFieldSetter(field, compiler) &&
-                !compiler.codegenWorld.hasInvokedSetter(field, compiler)) {
-              node.guaranteedType = type;
-            } else {
-              node.propagatedType = type;
+              // If there are no setters the initializer list type is
+              // guarenteed to remain constant.

[floitsch, 2012/07/11 12:15:31]

If there are no setters then the initializer list type is
guar*a*nteed to remain constant.

[Mads Ager (google), 2012/07/11 12:31:20]

Whooops, done!

+              //
+              // TODO(ager): Why is this treated differently from the
+              // case above? It seems to me that we could/should use
+              // the union of the types for the field setters and the
+              // initializer list here? It would give the same when
+              // there are none and potentially better information for
+              // more cases.
+              if (!compiler.codegenWorld.hasFieldSetter(field, compiler) &&
+                  !compiler.codegenWorld.hasInvokedSetter(field, compiler)) {
+                node.guaranteedType = type;
+              } else {
+                node.propagatedType = type;
+              }
             }
           }
           break;
       }
     }
   }
 
   HInstruction visitEquals(HEquals node) {
     // Determine if one of the operands is an HFieldGet.
     HFieldGet field;
@@ skipping 91 matching lines @@
             }
             break;
           default:
             assert(false);
             break;
         }
       }
     }
   }
 }