Issue 10704102: Cleanup attributes generation in dart:html.

Issue 10704102: Cleanup attributes generation in dart:html. (Closed)

Created:
8 years, 5 months ago by podivilov

Modified:
8 years, 5 months ago

Reviewers:
Anton Muhin, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup attributes generation in dart:html. R=antonm@google.com,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=9436

Patch Set 2 : . #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -121 lines)			Patch
M	lib/dom/scripts/systemfrog.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/dom/scripts/systemhtml.py	View	1	6 chunks	+63 lines, -99 lines	0 comments	Download
M	lib/dom/scripts/systemnative.py	View	1	2 chunks	+7 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm w/ comments addressed https://chromiumcodereview.appspot.com/10704102/diff/1/lib/dom/scripts/systemhtml.py File lib/dom/scripts/systemhtml.py (right): https://chromiumcodereview.appspot.com/10704102/diff/1/lib/dom/scripts/systemhtml.py#newcode279 lib/dom/scripts/systemhtml.py:279: 'Window.location', do you need to ...

8 years, 5 months ago (2012-07-04 20:01:08 UTC) #2

podivilov

8 years, 5 months ago (2012-07-05 09:38:58 UTC) #3

https://chromiumcodereview.appspot.com/10704102/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10704102/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:279: 'Window.location',
On 2012/07/04 20:01:08, antonmuhin wrote:
> do you need to duplicate Window.location?

Done.

https://chromiumcodereview.appspot.com/10704102/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:958: if not html_setter_name:
On 2012/07/04 20:01:08, antonmuhin wrote:
> cannot you change lines 955, 958 and 959 into: read_only =
IsReadOnly(attribute)
> or not html_setter_name ?

Done.

https://chromiumcodereview.appspot.com/10704102/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:962: if html_setter_name:
On 2012/07/04 20:01:08, antonmuhin wrote:
> assert(not html_setter_name or html_setter_name == html_name) ?

Done.

Expand Messages | Collapse Messages