Cleanup attributes generation in dart:html.

lib/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 451 matching lines @@
           '            goto fail;\n'
           '        RefPtr<ScriptCallStack> scriptCallStack(DartUtilities::createScriptCallStack());\n'
           '        if (!scriptCallStack->size())\n'
           '            return;\n',
           INDEX=len(node.arguments))
       arguments.extend(['scriptArguments', 'scriptCallStack'])
       return True
 
     return False
 
-  def AddAttribute(self, attribute):
-    getter = attribute
-    setter = attribute if not systembase.IsReadOnly(attribute) else None
-    if 'CheckSecurityForNode' in (getter or setter).ext_attrs:
+  def AddAttribute(self, attribute, html_name, read_only):
+    if 'CheckSecurityForNode' in attribute.ext_attrs:
       # FIXME: exclude from interface as well.
       return
 
-    dom_name = DartDomNameOfAttribute(getter or setter)
-    html_getter_name = self._html_system.RenameInHtmlLibrary(
-        self._interface.id, dom_name, 'get:', implementation_class=True)
-    html_setter_name = self._html_system.RenameInHtmlLibrary(
-        self._interface.id, dom_name, 'set:', implementation_class=True)
-
-    if getter and html_getter_name:
-      self._AddGetter(getter, html_getter_name)
-    if setter and html_setter_name:
-      self._AddSetter(setter, html_setter_name)
-
-  def AddSecondaryAttribute(self, interface, attribute):
-    self.AddAttribute(attribute)
+    self._AddGetter(attribute, html_name)
+    if not read_only:
+      self._AddSetter(attribute, html_name)
 
   def _AddGetter(self, attr, html_name):
     type_info = GetIDLTypeInfo(attr.type.id)
     dart_declaration = '%s get %s()' % (self._DartType(attr.type.id), html_name)
     is_custom = 'Custom' in attr.ext_attrs or 'CustomGetter' in attr.ext_attrs
     cpp_callback_name = self._GenerateNativeBinding(attr.id, 1,
         dart_declaration, 'Getter', is_custom)
     if is_custom:
       return
 
@@ skipping 256 matching lines @@
           check = '%s === _null' % argument_names[position]
           GenerateCall(operation, position, [check])
       GenerateCall(operation, len(operation.arguments), [])
 
   def AddOperation(self, info):
     self._AddOperation(info)
 
   def AddStaticOperation(self, info):
     self._AddOperation(info)
 
-  def AddSecondaryOperation(self, interface, info):
-    self.AddOperation(info)
+  def SecondaryContext(self, interface):
+    pass
 
   def _GenerateOperationNativeCallback(self, operation, arguments, cpp_callback_name):
     webcore_function_name = operation.ext_attrs.get('ImplementedAs', operation.id)
 
     parameter_definitions_emitter = emitter.Emitter()
     cpp_arguments = []
     raises_exceptions = self._GenerateCallWithHandling(
         operation, parameter_definitions_emitter, cpp_arguments)
     raises_exceptions = raises_exceptions or len(arguments) > 0 or operation.raises
 
@@ skipping 201 matching lines @@
 
 def _IsArgumentOptionalInWebCore(argument):
   return IsOptional(argument) and not 'Callback' in argument.ext_attrs
 
 def _ToWebKitName(name):
   name = name[0].lower() + name[1:]
   name = re.sub(r'^(hTML|uRL|jS|xML|xSLT)', lambda s: s.group(1).lower(),
                 name)
   return re.sub(r'^(create|exclusive)', lambda s: 'is' + s.group(1).capitalize(),
                 name)