Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 10702177: Fix the weird names that can occur in exceptions and logs when there is no (Closed)

Created:
8 years, 5 months ago by gram
Modified:
8 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix the weird names that can occur in exceptions and logs when there is no mock qualifier and due to the method names getting wrapped in quotes. To help this work properly, we now assert that a Mock has a name if it is passed in a LogEntryList, as opposed to allocating its own. We already said in the comments that this was a requirement but it wasn't enforced. Committed: https://code.google.com/p/dart/source/detail?r=9613

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -15 lines) Patch
M lib/unittest/description.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M lib/unittest/interfaces.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/unittest/mock.dart View 1 5 chunks +16 lines, -4 lines 0 comments Download
M tests/lib/unittest/unittest_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gram
8 years, 5 months ago (2012-07-12 17:59:07 UTC) #1
Siggi Cherem (dart-lang)
8 years, 5 months ago (2012-07-12 20:56:06 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698