Fix the weird names that can occur in exceptions and logs when there is no

lib/unittest/mock.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * The error formatter for mocking is a bit different from the default one
  * for unit testing; instead of the third argument being a 'reason'
  * it is instead a [signature] describing the method signature filter
  * that was used to select the logs that were verified.
  */
@@ skipping 120 matching lines @@
 
   /**
    * We keep our behavior specifications in a Map, which is keyed
    * by the [CallMatcher]. To make the keys unique and to get a
    * descriptive value for the [CallMatcher] we have this override
    * of [toString()].
    */
   String toString() {
     Description d = new StringDescription();
     d.addDescriptionOf(nameFilter);
+    // If the nameFilter was a simple string - i.e. just a method name -
+    // strip the quotes to make this more natural in appearance.
+    if (d.toString()[0] == "'") {
+      d.replace(d.toString().substring(1, d.toString().length - 1));
+    }
     d.add('(');
     for (var i = 0; i < argMatchers.length; i++) {
       if (i > 0) d.add(', ');
       d.addDescriptionOf(argMatchers[i]);
     }
     d.add(')');
     return d.toString();
   }
 
   /**
@@ skipping 158 matching lines @@
       d.addDescriptionOf(args[i]);
     }
     d.add(') ${action == _Action.THROW ? "threw" : "returned"} ');
     d.addDescriptionOf(value);
     return d.toString();
   }
 }
 
 /** Utility function for optionally qualified method names */
 String _qualifiedName(owner, String method) {
-  if (owner == null) {
+  if (owner == null || owner === anything) {
     return method;
   } else if (owner is Matcher) {
     Description d = new StringDescription();
     d.addDescriptionOf(owner);
     d.add('.');
     d.add(method);
     return d.toString();
   } else {
     return '$owner.$method';
   }
@@ skipping 11 matching lines @@
     logs = new List<LogEntry>();
   }
 
   /** Add a [LogEntry] to the log. */
   add(LogEntry entry) => logs.add(entry);
 
   /**
    * Create a new [LogEntryList] consisting of [LogEntry]s from
    * this list that match the specified [mockNameFilter] and [logFilter].
    * [mockNameFilter] can be null, a [String], a predicate [Function],
-   * or a [Matcher]. If [mockNameFilter] is null, only Mocks with no name
-   * will be checked.
+   * or a [Matcher]. If [mockNameFilter] is null, this is the same as
+   * [anything].
    * If [logFilter] is null, all entries in the log will be returned.
    * If [destructive] is true, the log entries are removed from the
    * original list.
    */
   LogEntryList getMatches([mockNameFilter,
                           CallMatcher logFilter,
                           Matcher actionMatcher,
                           bool destructive = false]) {
-    mockNameFilter = wrapMatcher(mockNameFilter);
+    if (mockNameFilter == null) {
+      mockNameFilter = anything;
+    } else {
+      mockNameFilter = wrapMatcher(mockNameFilter);
+    }
     if (logFilter == null) {
       logFilter = new CallMatcher();
     }
     String filterName = _qualifiedName(mockNameFilter, logFilter.toString());
     LogEntryList rtn = new LogEntryList(filterName);
     for (var i = 0; i < logs.length; i++) {
       LogEntry entry = logs[i];
       if (!mockNameFilter.matches(entry.mockName)) {
         continue;
       }
@@ skipping 390 matching lines @@
    * a shared [log]. If [throwIfNoBehavior] is true, any calls to methods
    * that have no defined behaviors will throw an exception; otherwise they
    * will be allowed and logged (but will not do anything).
    * If [enableLogging] is false, no logging will be done initially (whether
    * or not a [log] is supplied), but [logging] can be set to true later.
    */
   Mock.custom([this.name,
                this.log,
                throwIfNoBehavior = false,
                enableLogging = true]) : _throwIfNoBehavior = throwIfNoBehavior {
+    if (log != null && name == null) {
+      throw new Exception("Mocks with shared logs must have a name.");
+    }
     logging = enableLogging;
     _behaviors = new Map<String,Behavior>();
   }
 
   /**
    * [when] is used to create a new or extend an existing [Behavior].
    * A [CallMatcher] [filter] must be supplied, and the [Behavior]s for
    * that signature are returned (being created first if needed).
    *
    * Typical use case:
@@ skipping 153 matching lines @@
     if (log == null) {
       // This means we created the mock with logging off and have never turned
       // it on, so it doesn't make sense to get logs from such a mock.
       throw new
           Exception("Can't retrieve logs when logging was never enabled.");
     } else {
       return log.getMatches(name, logFilter, actionMatcher, destructive);
     }
   }
 }