Issue 10702110: Added Dartium support for JS to Dart PortSync calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10702110: Added Dartium support for JS to Dart PortSync calls (Closed)

Created:
8 years, 5 months ago by vsm

Modified:
8 years, 5 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, Anton Muhin

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added Dartium support for JS to Dart PortSync calls I addressed your test comments from the last cl - sorry for missing the last time. Committed: https://code.google.com/p/dart/source/detail?r=9431

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add new isolates file #

Patch Set 4 : Fixes for dart2js #

Total comments: 1

Patch Set 5 : Fixed tabbing #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+491 lines, -580 lines)			Patch
M	client/dart.js	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	lib/dom/templates/html/dartium/html_dartium.darttemplate	View		2 chunks	+18 lines, -44 lines	0 comments	Download
M	lib/dom/templates/html/dartium/impl_Window.darttemplate	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	lib/dom/templates/html/frog/html_frog.darttemplate	View	1 2 3	2 chunks	+9 lines, -202 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		3 chunks	+224 lines, -45 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View		2 chunks	+209 lines, -202 lines	0 comments	Download
A +	lib/html/src/Isolates.dart	View	1 2	6 chunks	+6 lines, -62 lines	0 comments	Download
M	tests/html/html.status	View	1 2 3 4	1 chunk	+1 line, -3 lines	0 comments	Download
M	tests/html/js_interop_3_test.dart	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	tests/html/js_interop_4_test.dart	View		5 chunks	+8 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kasperl

8 years, 5 months ago (2012-07-06 09:30:58 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/10702110/diff/6001/tests/html/html.status
File tests/html/html.status (right):

https://chromiumcodereview.appspot.com/10702110/diff/6001/tests/html/html.sta...
tests/html/html.status:14: js_interop_4_test: Fail	             # Dart-to-Dart
sync calls not implemented.
Tabbbbbb.

Expand Messages | Collapse Messages