Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: tests/html/js_interop_4_test.dart

Issue 10702110: Added Dartium support for JS to Dart PortSync calls (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixed tabbing Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/js_interop_3_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/js_interop_4_test.dart
diff --git a/tests/html/js_interop_4_test.dart b/tests/html/js_interop_4_test.dart
index f161b5df751821fb32f6ba7b786b53770779f289..4ad3e042c17d82e1e6245ab3e601fb15349dde91 100644
--- a/tests/html/js_interop_4_test.dart
+++ b/tests/html/js_interop_4_test.dart
@@ -8,8 +8,9 @@
#import('dart:html');
#import('dart:isolate');
-const testData = const [1, '2', 'true'];
+final testData = const [1, '2', 'true'];
+// TODO(vsm): Convert all DOM isolate tests to the new syntax.
class TestIsolate extends Isolate {
TestIsolate() : super();
@@ -28,9 +29,9 @@ main() {
// Test that our interop scheme also works from Dart to Dart.
test('dart-to-dart-same-isolate', () {
var fun = expectAsync1((message) {
- Expect.listEquals(testData, message);
- return message.length;
- });
+ Expect.listEquals(testData, message);
+ return message.length;
+ });
var port1 = new ReceivePortSync();
port1.receive(fun);
@@ -43,8 +44,6 @@ main() {
// Test across isolate boundary.
test('dart-to-dart-cross-isolate', () {
- var done = expectAsync0(() {});
-
var fun1 = (message) {
Expect.listEquals(testData, message);
return message.length;
@@ -54,10 +53,10 @@ main() {
port1.receive(fun1);
window.registerPort('fun1', port1.toSendPort());
+ // TODO(vsm): Investigate why this needs to be called asynchronously.
+ var done = expectAsync0(() {});
var fun2 = (message) {
Expect.equals(3, message);
-
- // TODO(vsm): Investigate why this needs to be called asynchronously.
window.setTimeout(done, 0);
};
@@ -65,6 +64,6 @@ main() {
port2.receive(fun2);
window.registerPort('fun2', port2.toSendPort());
- new TestIsolate().spawn().then((p) {});
+ new TestIsolate().spawn();
});
}
« no previous file with comments | « tests/html/js_interop_3_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698