Issue 10701131: Stop passing location argument to run time calls, since it is stored in the pc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10701131: Stop passing location argument to run time calls, since it is stored in the pc (Closed)

Created:
8 years, 5 months ago by regis

Modified:
8 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Stop passing location argument to run time calls, since it is stored in the pc descriptor. Various cleanups. Committed: https://code.google.com/p/dart/source/detail?r=9538

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -102 lines)			Patch
M	runtime/vm/bootstrap_natives.cc	View	1	1 chunk	+3 lines, -8 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1	8 chunks	+71 lines, -61 lines	0 comments	Download
M	runtime/vm/exceptions_test.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	6 chunks	+3 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	6 chunks	+3 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	3 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/native_entry_test.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/stack_frame_test.cc	View	1	1 chunk	+3 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_ia32_test.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64_test.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10701131/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://chromiumcodereview.appspot.com/10701131/diff/1/runtime/vm/code_generator.cc#newcode150 runtime/vm/code_generator.cc:150: return 0; Is 0 a valid token index? ...

8 years, 5 months ago (2012-07-10 23:18:37 UTC) #2

regis

8 years, 5 months ago (2012-07-10 23:52:07 UTC) #3

Thanks

https://chromiumcodereview.appspot.com/10701131/diff/1/runtime/vm/code_genera...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/10701131/diff/1/runtime/vm/code_genera...
runtime/vm/code_generator.cc:150: return 0;
On 2012/07/10 23:18:37, srdjan wrote:
> Is 0 a valid token index? If so, return -1 instead.

Done.

Expand Messages | Collapse Messages

Issue 10701131: Stop passing location argument to run time calls, since it is stored in the pc (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages