runtime/vm/intermediate_language_ia32.cc - Issue 10701131: Stop passing location argument to run time calls, since it is stored in the pc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10701131: Stop passing location argument to run time calls, since it is stored in the pc (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

===================================================================

--- runtime/vm/intermediate_language_ia32.cc (revision 9536)

+++ runtime/vm/intermediate_language_ia32.cc (working copy)

@@ -182,7 +182,6 @@

__ CompareObject(obj, compiler->bool_false());

__ j(EQUAL, &done, Assembler::kNearJump);

- __ pushl(Immediate(Smi::RawValue(token_pos()))); // Source location.

__ pushl(obj); // Push the source object.

compiler->GenerateCallRuntime(cid(),

token_pos(),

@@ -1061,7 +1060,6 @@

// Push the result place holder initialized to NULL.

__ PushObject(Object::ZoneHandle());

- __ pushl(Immediate(Smi::RawValue(token_pos())));

__ PushObject(cls);

__ pushl(type_arguments);

__ pushl(instantiator_type_arguments);

@@ -1069,9 +1067,9 @@

token_pos(),

try_index(),

kAllocateObjectWithBoundsCheckRuntimeEntry);

- // Pop instantiator type arguments, type arguments, class, and

+ // Pop instantiator type arguments, type arguments, and class.

// source location.

- __ Drop(4);

+ __ Drop(3);

__ popl(result); // Pop new instance.

}

« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »