Issue 10700112: _html_library_custom members are only custom in frog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10700112: _html_library_custom members are only custom in frog. (Closed)

Created:
8 years, 5 months ago by podivilov

Modified:
8 years, 5 months ago

Reviewers:
Anton Muhin, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

_html_library_custom members are only custom in frog. R=antonm@google.com,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=9444

Patch Set 2 : . #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	lib/dom/scripts/systemhtml.py	View	1	4 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://chromiumcodereview.appspot.com/10700112/diff/1/lib/dom/scripts/systemhtml.py File lib/dom/scripts/systemhtml.py (right): https://chromiumcodereview.appspot.com/10700112/diff/1/lib/dom/scripts/systemhtml.py#newcode1343 lib/dom/scripts/systemhtml.py:1343: return '%s.%s' % (self._html_interface_name, member_name) in self._custom_members nit: ...

8 years, 5 months ago (2012-07-05 16:00:15 UTC) #2

sra1

https://chromiumcodereview.appspot.com/10700112/diff/1/lib/dom/scripts/systemhtml.py File lib/dom/scripts/systemhtml.py (right): https://chromiumcodereview.appspot.com/10700112/diff/1/lib/dom/scripts/systemhtml.py#newcode1345 lib/dom/scripts/systemhtml.py:1345: _custom_members = set([ Please keep these tables at the ...

8 years, 5 months ago (2012-07-06 07:20:11 UTC) #3

podivilov

8 years, 5 months ago (2012-07-06 16:18:19 UTC) #4

https://chromiumcodereview.appspot.com/10700112/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10700112/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:1345: _custom_members = set([
On 2012/07/06 07:20:11, sra1 wrote:
> Please keep these tables at the top of the file.  Maybe change the name, e.g.
> _html_js_custom_members

Done.

Expand Messages | Collapse Messages

Issue 10700112: _html_library_custom members are only custom in frog. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages