_html_library_custom members are only custom in frog.

lib/dom/scripts/systemhtml.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the system to generate
 Dart:html APIs from the IDL database."""
 
 import emitter
 
@@ skipping 253 matching lines @@
     "Node.get:nodeValue",
     "Node.set:nodeValue",
     "Node.get:CDATA_SECTION_NODE",
     "Node.get:nodeName",
     "Node.lookupPrefix",
     "Node.get:PROCESSING_INSTRUCTION_NODE",
     "IFrameElement.get:contentDocument",
     "Window.get:frameElement",
     ])
 
-_html_library_custom = set([
-    'IFrameElement.contentWindow',
-    'Window.document',
-    'Window.top',
-    'Window.location',
-    'Window.open',
-    'IDBDatabase.transaction',
-    ])
-
 # This map controls merging of interfaces in dart:html library.
 # All constants, attributes, and operations of merged interface (key) are
 # added to target interface (value). All references to the merged interface
 # (e.g. parameter types, return types, parent interfaces) are replaced with
 # target interface. There are two important restrictions:
 # 1) Merged and target interfaces shouldn't have common members, otherwise there
 # would be duplicated declarations in generated Dart code.
 # 2) Merged interface should be direct child of target interface, so the
 # children of merged interface are not affected by the merge.
 # As a consequence, target interface implementation and its direct children
@@ skipping 942 matching lines @@
             TYPE=self._NarrowInputType(element_type))
 
     # TODO(sra): Use separate mixins for mutable implementations of List<T>.
     # TODO(sra): Use separate mixins for typed array implementations of List<T>.
     if self._interface.id != 'NodeList':
       template_file = 'immutable_list_mixin.darttemplate'
       template = self._system._templates.Load(template_file)
       self._members_emitter.Emit(template, E=self._shared.DartType(element_type))
 
   def AddAttribute(self, attribute, html_name, read_only):
-    if self._shared.IsCustomInHtmlLibrary(self._interface, attribute.id):
+    if self._HasCustomImplementation(attribute.id):
       return
 
     if attribute.id != html_name:
       self._AddRenamingGetter(attribute, html_name)
       if not read_only:
         self._AddRenamingSetter(attribute, html_name)
       return
 
     # If the attribute is shadowing, we can't generate a shadowing
     # field (Issue 1633).
@@ skipping 54 matching lines @@
         ' native "this.$NAME = value;";\n',
         HTML_NAME=html_name,
         NAME=attr.id,
         TYPE=self._NarrowInputType(attr.type.id))
 
   def AddOperation(self, info):
     """
     Arguments:
       info: An OperationInfo object.
     """
-    if self._shared.IsCustomInHtmlLibrary(self._interface, info.name):
+    if self._HasCustomImplementation(info.name):
       return
 
     html_name = self._shared.RenameInHtmlLibrary(
         self._interface.id, info.name, implementation_class=True)
     if not html_name:
       return
 
     # Do we need a native body?
     if html_name != info.declared_name:
       return_type = self._NarrowOutputType(info.type_name)
@@ skipping 10 matching lines @@
           '  $TYPE $(HTML_NAME)($PARAMS) native "$NAME";\n')
     else:
       self._members_emitter.Emit(
           '\n'
           '  $TYPE $NAME($PARAMS) native;\n',
           TYPE=self._NarrowOutputType(info.type_name),
           NAME=info.name,
           PARAMS=info.ParametersImplementationDeclaration(
               lambda type_name: self._NarrowInputType(type_name)))
 
+  def _HasCustomImplementation(self, member_name):
+    return '%s.%s' % (self._html_interface_name, member_name) in self._custom_members

[Anton Muhin, 2012/07/05 16:00:15]

nit: class name instead of self should be preferred here imho.

+
+  _custom_members = set([

[sra1, 2012/07/06 07:20:11]

Please keep these tables at the top of the file.  Maybe change the name, e.g.
_html_js_custom_members

[podivilov, 2012/07/06 16:18:19]

Done.

+      'IFrameElement.contentWindow',
+      'Window.document',
+      'Window.top',
+      'Window.location',
+      'Window.open',
+      'IDBDatabase.transaction',
+      ])
+
 # ------------------------------------------------------------------------------
 
 class HtmlFrogSystem(HtmlSystem):
 
   def __init__(self, templates, database, emitters, output_dir):
     super(HtmlFrogSystem, self).__init__(
         templates, database, emitters, output_dir)
 
   def ImplementationGenerator(self, interface):
     return HtmlFrogClassGenerator(self, interface)
@@ skipping 25 matching lines @@
             Collect(database.GetInterface(parent.type.id),
                     seen, collected)
 
   inheritance_closure = {}
   for interface in database.GetInterfaces():
     seen = set()
     collected = []
     Collect(interface, seen, collected)
     inheritance_closure[interface.id] = collected
   return inheritance_closure