Issue 10700111: Eliminate the type distinction between BindInstr and DoInstr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10700111: Eliminate the type distinction between BindInstr and DoInstr. (Closed)

Created:
8 years, 5 months ago by Kevin Millikin (Google)

Modified:
8 years, 5 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Eliminate the type distinction between BindInstr and DoInstr. Represent the distinction between computations whose value is used and computations whose value is unused with a data member (instead of a separate type). R=fschneider@google.com,srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9416

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -141 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View		4 chunks	+33 lines, -42 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View		2 chunks	+6 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	11 chunks	+12 lines, -52 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		2 chunks	+0 lines, -20 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_test.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Google)

The name BindInstr is wrong now, but it is now just a thin wrapper around ...

8 years, 5 months ago (2012-07-05 09:16:32 UTC) #1

LGTM.