runtime/vm/intermediate_language_ia32.cc - Issue 10700111: Eliminate the type distinction between BindInstr and DoInstr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10700111: Eliminate the type distinction between BindInstr and DoInstr. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Eliminate an unnecessary virtual function. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc

index dd79244c625433dde4f5ca3260c1424511a8c982..db90a0acd970923c51afcab17a218e6ca2d5fbe3 100644

--- a/runtime/vm/intermediate_language_ia32.cc

+++ b/runtime/vm/intermediate_language_ia32.cc

@@ -32,7 +32,7 @@ LocationSummary* Computation::MakeCallSummary() {

void BindInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

computation()->EmitNativeCode(compiler);

- if (locs()->out().kind() == Location::kRegister) {

+ if (is_used() && locs()->out().kind() == Location::kRegister) {

// TODO(vegorov): this should really happen only for comparisons fused

// with branches. Currrently IR does not provide an easy way to remove

// instructions from the graph so we just leave fused comparison in it

« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_test.cc » ('j') | no next file with comments »