Make per-interface generators an implementation detail of a system.

Make per-interface generators an implementation detail of a system.

DartGenerator shouldn't know about per-interface generators
as it stiffles further refactoring and makes code reuse harder.

R=antonm@google.com,sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=9239

[Anton Muhin, 2012-06-27 18:13:55]

Overall, if possible, keep those changes smaller: you're changing too much in
one go and it's difficult to track everything.

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/dar...
File lib/dom/scripts/dartgenerator.py (right):

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/dar...
lib/dom/scripts/dartgenerator.py:217:
interface.ext_attrs['synthesizedSuperInterfaceName'] = super_name
I am really uneasy about this method.  I can understand you desire not to thread
it around though.

A question: why you care about super interface coming from super_database?  What
if it's missing or renamed in proper database?

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/dar...
lib/dom/scripts/dartgenerator.py:300: generator = DummyInterfaceGenerator(self,
interface)
nit: make in oneliner?

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/gen...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/gen...
lib/dom/scripts/generator.py:166: return any(token in thing.annotations for
token in filter)
nit: as you hard code filter, code in this method should be ways simpler, no?

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/sys...
File lib/dom/scripts/systemfrog.py (right):

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemfrog.py:42: generator = FrogInterfaceGenerator(self,
interface, template, dart_code)
nit: again, single line?

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/sys...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemhtml.py:794: generator = HtmlDartInterfaceGenerator(
ditto, overall, should be henerators a classes, or functions on its own (maybe
hiding a class behind)

[podivilov, 2012-06-27 18:48:07]

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/dar...
File lib/dom/scripts/dartgenerator.py (right):

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/dar...
lib/dom/scripts/dartgenerator.py:217:
interface.ext_attrs['synthesizedSuperInterfaceName'] = super_name
On 2012/06/27 18:13:55, antonmuhin wrote:
> I am really uneasy about this method.  I can understand you desire not to
thread
> it around though.
> 
> A question: why you care about super interface coming from super_database? 
What
> if it's missing or renamed in proper database?

It's a bit hacky, but synthesized annotations fit very well here.

As I understand, it's a part of rename hell. The database contains original
WebKit names, but we want some dart interfaces to be named differently -
according to webkit_renames. Let me cleanup this in a separate cl.

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/dar...
lib/dom/scripts/dartgenerator.py:300: generator = DummyInterfaceGenerator(self,
interface)
On 2012/06/27 18:13:55, antonmuhin wrote:
> nit: make in oneliner?

Done.

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/gen...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/gen...
lib/dom/scripts/generator.py:166: return any(token in thing.annotations for
token in filter)
On 2012/06/27 18:13:55, antonmuhin wrote:
> nit: as you hard code filter, code in this method should be ways simpler, no?

Done.

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/sys...
File lib/dom/scripts/systemfrog.py (right):

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemfrog.py:42: generator = FrogInterfaceGenerator(self,
interface, template, dart_code)
On 2012/06/27 18:13:55, antonmuhin wrote:
> nit: again, single line?

Done.

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/sys...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10700006/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemhtml.py:794: generator = HtmlDartInterfaceGenerator(
On 2012/06/27 18:13:55, antonmuhin wrote:
> ditto, overall, should be henerators a classes, or functions on its own (maybe
> hiding a class behind)

There should be a class to keep per-interface state. Hiding it behind a function
is possible, but I don't see much benefit in it.

[Anton Muhin, 2012-06-27 19:03:10]

lgtm