Make per-interface generators an implementation detail of a system.

lib/dom/scripts/generator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for systems to generate
 Dart APIs from the IDL database."""
 
 import copy
 import re
@@ skipping 143 matching lines @@
 def MakeNativeSpec(javascript_binding_name):
   if javascript_binding_name in _frog_dom_custom_native_specs:
     return _frog_dom_custom_native_specs[javascript_binding_name]
   else:
     # Make the class 'hidden' so it is dynamically patched at runtime.  This
     # is useful not only for browser compat, but to allow code that links
     # against dart:dom_deprecated to load in a worker isolate.
     return '*' + javascript_binding_name
 
 
-def MatchSourceFilter(filter, thing):
-  if not filter:
-    return True
-  else:
-    return any(token in thing.annotations for token in filter)
+def MatchSourceFilter(thing):
+  filter = ['WebKit', 'Dart']
+  return any(token in thing.annotations for token in filter)

[Anton Muhin, 2012/06/27 18:13:55]

nit: as you hard code filter, code in this method should be ways simpler, no?

[podivilov, 2012/06/27 18:48:07]

Done.

 
 
 def DartType(idl_type_name):
   return GetIDLTypeInfo(idl_type_name).dart_type()
 
 
 class ParamInfo(object):
   """Holder for various information about a parameter of a Dart operation.
 
   Attributes:
@@ skipping 660 matching lines @@
 
   match = re.match(r'sequence<(\w+)>$', idl_type_name)
   if match:
     return SequenceIDLTypeInfo(idl_type_name, GetIDLTypeInfo(match.group(1)))
 
   match = re.match(r'(\w+)\[\]$', idl_type_name)
   if match:
     return SequenceIDLTypeInfo(idl_type_name, GetIDLTypeInfo(match.group(1)))
 
   return IDLTypeInfo(idl_type_name)