Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10698108: Stop passing HtmlSystemShared around and move html renaming to IDLTypeInfo. (Closed)

Created:
8 years, 5 months ago by podivilov
Modified:
8 years, 5 months ago
Reviewers:
Anton Muhin, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Stop passing HtmlSystemShared around and move html renaming to IDLTypeInfo. R=antonm@google.com,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=9636

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -151 lines) Patch
M lib/dom/scripts/dartdomgenerator.py View 1 3 chunks +14 lines, -7 lines 0 comments Download
M lib/dom/scripts/dartgenerator.py View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/scripts/generator.py View 1 7 chunks +20 lines, -24 lines 0 comments Download
M lib/dom/scripts/systembase.py View 1 2 chunks +6 lines, -2 lines 0 comments Download
M lib/dom/scripts/systemfrog.py View 1 5 chunks +13 lines, -16 lines 0 comments Download
M lib/dom/scripts/systemhtml.py View 1 21 chunks +53 lines, -68 lines 0 comments Download
M lib/dom/scripts/systeminterface.py View 1 6 chunks +8 lines, -8 lines 0 comments Download
M lib/dom/scripts/systemnative.py View 1 7 chunks +2 lines, -25 lines 0 comments Download
M lib/html/frog/html_frog.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
podivilov
8 years, 5 months ago (2012-07-05 15:44:49 UTC) #1
Anton Muhin
https://chromiumcodereview.appspot.com/10698108/diff/1/lib/dom/scripts/dartgenerator.py File lib/dom/scripts/dartgenerator.py (right): https://chromiumcodereview.appspot.com/10698108/diff/1/lib/dom/scripts/dartgenerator.py#newcode192 lib/dom/scripts/dartgenerator.py:192: IDLTypeInfo.interface_renames = interface_renames that doesn't look like a simplification---it's ...
8 years, 5 months ago (2012-07-05 15:55:53 UTC) #2
podivilov
https://chromiumcodereview.appspot.com/10698108/diff/1/lib/dom/scripts/dartgenerator.py File lib/dom/scripts/dartgenerator.py (right): https://chromiumcodereview.appspot.com/10698108/diff/1/lib/dom/scripts/dartgenerator.py#newcode192 lib/dom/scripts/dartgenerator.py:192: IDLTypeInfo.interface_renames = interface_renames On 2012/07/05 15:55:53, antonmuhin wrote: > ...
8 years, 5 months ago (2012-07-05 16:00:06 UTC) #3
Anton Muhin
https://chromiumcodereview.appspot.com/10698108/diff/1/lib/dom/scripts/dartgenerator.py File lib/dom/scripts/dartgenerator.py (right): https://chromiumcodereview.appspot.com/10698108/diff/1/lib/dom/scripts/dartgenerator.py#newcode192 lib/dom/scripts/dartgenerator.py:192: IDLTypeInfo.interface_renames = interface_renames I do agree w/ it. But ...
8 years, 5 months ago (2012-07-05 16:02:10 UTC) #4
podivilov
PTAL. https://chromiumcodereview.appspot.com/10698108/diff/1/lib/dom/scripts/dartgenerator.py File lib/dom/scripts/dartgenerator.py (right): https://chromiumcodereview.appspot.com/10698108/diff/1/lib/dom/scripts/dartgenerator.py#newcode192 lib/dom/scripts/dartgenerator.py:192: IDLTypeInfo.interface_renames = interface_renames On 2012/07/05 16:02:11, Anton Mukhin ...
8 years, 5 months ago (2012-07-13 15:39:24 UTC) #5
Anton Muhin
8 years, 5 months ago (2012-07-13 15:47:18 UTC) #6 
lgtm

Powered by Google App Engine
This is Rietveld 408576698