Stop passing HtmlSystemShared around and move html renaming to IDLTypeInfo.

lib/dom/scripts/dartgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module generates Dart APIs from the IDL database."""
 
 import emitter
 import idlnode
 import logging
@@ skipping 168 matching lines @@
       if HasAnnotations(interface):
         interface.constants = filter(HasAnnotations, interface.constants)
         interface.attributes = filter(HasAnnotations, interface.attributes)
         interface.operations = filter(HasAnnotations, interface.operations)
         interface.parents = filter(HasAnnotations, interface.parents)
       else:
         database.DeleteInterface(interface.id)
 
     self.FilterMembersWithUnidentifiedTypes(database)
 
-  def Generate(self, database, system, super_database=None, webkit_renames={}):
+  def Generate(self, database, system, super_database=None, webkit_renames={},
+               interface_renames={}):
     self._database = database
+    IDLTypeInfo.interface_renames = interface_renames

[Anton Muhin, 2012/07/05 15:55:53]

that doesn't look like a simplification---it's hard to trace global state.

[podivilov, 2012/07/05 16:00:06]

Dart interface renames naturally belong to type registry. Hiding renames in
IDLTypeInfo.dart_type() greatly simplifies dart code generation in dart:html.

[Anton Muhin, 2012/07/05 16:02:11]

I do agree w/ it.  But I hate this temporary set renames field on the class (aka
global state).

I think we'd better thread this thing around.

On 2012/07/05 16:00:06, podivilov wrote:

[podivilov, 2012/07/13 15:39:24]

Done.

 
     # Collect interfaces
     interfaces = []
     for interface in database.GetInterfaces():
       if not MatchSourceFilter(interface):
         # Skip this interface since it's not present in the required source
         _logger.info('Omitting interface - %s' % interface.id)
         continue
       interfaces.append(interface)
 
@@ skipping 26 matching lines @@
       if info:
        system.ProcessCallback(interface, info)
       else:
         if 'Callback' in interface.ext_attrs:
           _logger.info('Malformed callback: %s' % interface.id)
         _logger.info('Generating %s' % interface.id)
         system.ProcessInterface(interface)
 
     system.GenerateLibraries()
     system.Finish()
+    IDLTypeInfo.interface_renames = {}
 
   def _PreOrderInterfaces(self, interfaces):
     """Returns the interfaces in pre-order, i.e. parents first."""
     seen = set()
     ordered = []
     def visit(interface):
       if interface.id in seen:
         return
       seen.add(interface.id)
       for parent in interface.parents:
@@ skipping 90 matching lines @@
         PARAMETERS=constructor_info.ParametersImplementationDeclaration())
 
   def FinishInterface(self):
     pass
 
   def AddTypedArrayConstructors(self, element_type):
     pass
 
   def AddEventAttributes(self, event_attrs):
     pass