Issue 10696165: Don't allow OS::SNPrint or OS::VSNPrint to return negative values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10696165: Don't allow OS::SNPrint or OS::VSNPrint to return negative values. (Closed)

Created:
8 years, 5 months ago by turnidge

Modified:
8 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, mjurczyk

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Don't allow OS::SNPrint or OS::VSNPrint to return negative values. If we encounter conditions that would have caused vsnprintf to return a negative value, then something pretty wild is going on. We choose to terminate the vm when this occurs. This fixes security bug 1745. Committed: https://code.google.com/p/dart/source/detail?r=9558

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -12 lines)			Patch
M	tests/vm/vm.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	vm/os.h	View	1	1 chunk	+14 lines, -9 lines	0 comments	Download
M	vm/os_linux.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	vm/os_macos.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	vm/os_test.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	vm/os_win.cc	View	1	2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages