vm/os_test.cc - Issue 10696165: Don't allow OS::SNPrint or OS::VSNPrint to return negative values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/os_test.cc

Issue 10696165: Don't allow OS::SNPrint or OS::VSNPrint to return negative values. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/os_test.cc

===================================================================

--- vm/os_test.cc (revision 9556)

+++ vm/os_test.cc (working copy)

@@ -38,6 +38,14 @@

}

+// This test is expected to crash when it runs.

+UNIT_TEST_CASE(SNPrint_BadArgs) {

+ int width = kMaxInt32;

+ int num = 7;

+ OS::SNPrint(NULL, 0, "%*d%*d", width, num, width, num);

UNIT_TEST_CASE(OsFuncs) {

EXPECT(Utils::IsPowerOfTwo(OS::ActivationFrameAlignment()));

EXPECT(Utils::IsPowerOfTwo(OS::PreferredCodeAlignment()));

« no previous file with comments | « vm/os_macos.cc ('k') | vm/os_win.cc » ('j') | no next file with comments »