Issue 10695079: Another small batch of resolver tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10695079: Another small batch of resolver tests (Closed)

Created:
8 years, 5 months ago by zundel

Modified:
8 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Another small batch of resolver tests Removed some logic that duplicates errors from the parsing step Committed: https://code.google.com/p/dart/source/detail?r=9356

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -20 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	3 chunks	+3 lines, -5 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View	5 chunks	+2 lines, -13 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

https://chromiumcodereview.appspot.com/10695079/diff/1/compiler/java/com/google/dart/compiler/resolver/Resolver.java File compiler/java/com/google/dart/compiler/resolver/Resolver.java (left): https://chromiumcodereview.appspot.com/10695079/diff/1/compiler/java/com/google/dart/compiler/resolver/Resolver.java#oldcode248 compiler/java/com/google/dart/compiler/resolver/Resolver.java:248: } already flagged in parser

8 years, 5 months ago (2012-07-03 13:00:37 UTC) #1

LGTM

Expand Messages | Collapse Messages