Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 10695079: Another small batch of resolver tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
index 0c5271d14c5deaa1a08da4e814a2863833f89129..af79b8bdec9e10117a08281ff434c2f620a7dae4 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
@@ -246,9 +246,6 @@ public class Resolver {
ResolverErrorCode.DUPLICATE_PARAMETER,
ResolverErrorCode.DUPLICATE_PARAMETER_WARNING);
}
zundel 2012/07/03 13:00:37 already flagged in parser
- if (parameter.getDefaultExpr() != null) {
- onError(parameter.getDefaultExpr(), ResolverErrorCode.DEFAULT_VALUE_IN_TYPEDEF);
- }
}
getContext().popScope();
@@ -325,7 +322,8 @@ public class Resolver {
ClassElement defaultClass = classElement.getDefaultClass().getElement();
if (defaultClass.isInterface()) {
- onError(cls.getDefaultClass(), ResolverErrorCode.DEFAULT_MUST_SPECIFY_CLASS);
+ onError(cls.getDefaultClass().getExpression(),
+ ResolverErrorCode.DEFAULT_MUST_SPECIFY_CLASS);
}
// Make sure the default class matches the interface type parameters
@@ -1768,7 +1766,7 @@ public class Resolver {
(ClassElement) currentHolder, x.getName().getName());
if (element == null || element.isStatic() || element.getModifiers().isAbstractField()) {
diagnoseErrorInInitializer(x.getName());
- }
+ }
recordElement(x.getName(), element);
}

Powered by Google App Engine
This is Rietveld 408576698