Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 10693123: Use better names for closures and static variables. (Closed)

Created:
8 years, 5 months ago by floitsch
Modified:
8 years, 5 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use better names for closures and static variables. This increases the code size, but goes away with a minifier. Committed: https://code.google.com/p/dart/source/detail?r=9468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -31 lines) Patch
M lib/compiler/implementation/elements/elements.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/compiler/implementation/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/enqueue.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/compiler/implementation/namer.dart View 2 chunks +50 lines, -20 lines 0 comments Download
M lib/compiler/implementation/ssa/closure.dart View 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
floitsch
8 years, 5 months ago (2012-07-09 14:09:26 UTC) #1
Mads Ager (google)
8 years, 5 months ago (2012-07-09 14:19:29 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698