lib/compiler/implementation/enqueue.dart - Issue 10693123: Use better names for closures and static variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/enqueue.dart

Issue 10693123: Use better names for closures and static variables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/enqueue.dart

diff --git a/lib/compiler/implementation/enqueue.dart b/lib/compiler/implementation/enqueue.dart

index 7bb1ce4e777d23a647112c7c84d152b76558348d..b2ff2a0985dfcb9c952f669c548a925e7eeb745a 100644

--- a/lib/compiler/implementation/enqueue.dart

+++ b/lib/compiler/implementation/enqueue.dart

@@ -93,8 +93,7 @@ class Enqueuer {

// of closures. They are processed as part of the enclosing function and not

// present as a separate element (the call to the closure will be a member

// function).

- var closure = const SourceString("Closure");

- return element.isMember() && element.getEnclosingClass().name != closure;

+ return element.isMember() && !element.getEnclosingClass().isClosure();

}

void registerRecompilationCandidate(Element element,

« no previous file with comments | « lib/compiler/implementation/emitter.dart ('k') | lib/compiler/implementation/namer.dart » ('j') | no next file with comments »