Issue 10693039: Terminate event handler thread on isolate shutdown.

Issue 10693039: Terminate event handler thread on isolate shutdown. (Closed)

Created:
8 years, 5 months ago by Mads Ager (google)

Modified:
8 years, 5 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Terminate event handler thread on isolate shutdown. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9251

Patch Set 2 : Address comment. #

Patch Set 3 : Adding new file to gyp file #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -18 lines)			Patch
M	runtime/bin/builtin_impl_sources.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/eventhandler.h	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/bin/eventhandler.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/eventhandler_linux.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/bin/eventhandler_linux.cc	View	1	6 chunks	+11 lines, -2 lines	0 comments	Download
M	runtime/bin/eventhandler_macos.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/bin/eventhandler_macos.cc	View	1	6 chunks	+11 lines, -2 lines	0 comments	Download
M	runtime/bin/eventhandler_win.h	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/bin/eventhandler_win.cc	View	1	6 chunks	+15 lines, -5 lines	0 comments	Download
A	runtime/bin/isolate_data.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	runtime/bin/main.cc	View		5 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/10693039/diff/1/runtime/bin/eventhandler_linux.cc File runtime/bin/eventhandler_linux.cc (right): https://chromiumcodereview.appspot.com/10693039/diff/1/runtime/bin/eventhandler_linux.cc#newcode380 runtime/bin/eventhandler_linux.cc:380: while (true) { Maybe "while (!handler->shutdown_)" here and ...

8 years, 5 months ago (2012-06-29 11:54:11 UTC) #2

Mads Ager (google)

8 years, 5 months ago (2012-06-29 14:30:24 UTC) #3

https://chromiumcodereview.appspot.com/10693039/diff/1/runtime/bin/eventhandl...
File runtime/bin/eventhandler_linux.cc (right):

https://chromiumcodereview.appspot.com/10693039/diff/1/runtime/bin/eventhandl...
runtime/bin/eventhandler_linux.cc:380: while (true) {
On 2012/06/29 11:54:11, Søren Gjesse wrote:
> Maybe "while (!handler->shutdown_)" here and no new if at the bottom of the
> loop?
> 
> Same for Mac OS and Windows.

Absolutely! Thanks for catching that.

https://chromiumcodereview.appspot.com/10693039/diff/1/runtime/bin/eventhandl...
File runtime/bin/eventhandler_linux.h (right):

https://chromiumcodereview.appspot.com/10693039/diff/1/runtime/bin/eventhandl...
runtime/bin/eventhandler_linux.h:96: void StartEventHandler();
On 2012/06/29 11:54:11, Søren Gjesse wrote:
> Should StartEventHandler be just Start then?

Done. Thanks.

Expand Messages | Collapse Messages